Merge branch 'main' into fix/tests-ctx #4658
plyr4Annotations
41 errors
|
[golangci] runtime/kubernetes/mock.go#L143:
runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
[golangci] runtime/kubernetes/pod_tracker.go#L226:
runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
[golangci] runtime/kubernetes/build.go#L22:
runtime/kubernetes/build.go#L22
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] runtime/kubernetes/image.go#L32:
runtime/kubernetes/image.go#L32
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] runtime/kubernetes/image.go#L39:
runtime/kubernetes/image.go#L39
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] runtime/kubernetes/pod_tracker_test.go#L184:
runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] runtime/kubernetes/pod_tracker_test.go#L258:
runtime/kubernetes/pod_tracker_test.go#L258
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] runtime/kubernetes/pod_tracker_test.go#L327:
runtime/kubernetes/pod_tracker_test.go#L327
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] runtime/kubernetes/pod_tracker_test.go#L373:
runtime/kubernetes/pod_tracker_test.go#L373
expressions should not be cuddled with blocks (wsl)
|
|
[golangci] internal/context/context_test.go#L132:
internal/context/context_test.go#L132
if statements should only be cuddled with assignments (wsl)
|
|
[golangci] internal/context/context_test.go#L148:
internal/context/context_test.go#L148
assignments should only be cuddled with other assignments (wsl)
|
|
[golangci] internal/context/context_test.go#L149:
internal/context/context_test.go#L149
only one cuddle assignment allowed before if statement (wsl)
|
|
[golangci] executor/linux/build_test.go#L1100:
executor/linux/build_test.go#L1100
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] executor/linux/build_test.go#L1126:
executor/linux/build_test.go#L1126
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] executor/linux/build_test.go#L1198:
executor/linux/build_test.go#L1198
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] executor/linux/secret.go#L209:
executor/linux/secret.go#L209
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
|
|
[golangci] executor/linux/secret.go#L226:
executor/linux/secret.go#L226
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
|
|
[golangci] executor/linux/secret.go#L243:
executor/linux/secret.go#L243
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
|
|
[golangci] executor/linux/build_test.go#L982:
executor/linux/build_test.go#L982
ranges should only be cuddled with assignments used in the iteration (wsl)
|
|
[golangci] executor/linux/build_test.go#L1605:
executor/linux/build_test.go#L1605
if statements should only be cuddled with assignments (wsl)
|
|
[golangci] executor/linux/build_test.go#L1852:
executor/linux/build_test.go#L1852
if statements should only be cuddled with assignments (wsl)
|
|
[golangci] executor/linux/build_test.go#L389:
executor/linux/build_test.go#L389
if statements should only be cuddled with assignments used in the if statement itself (wsl)
|
|
[golangci] executor/linux/build_test.go#L605:
executor/linux/build_test.go#L605
defer statements should only be cuddled with expressions on same variable (wsl)
|
|
[golangci] executor/linux/build_test.go#L987:
executor/linux/build_test.go#L987
if statements should only be cuddled with assignments used in the if statement itself (wsl)
|
|
[golangci] executor/linux/build_test.go#L1757:
executor/linux/build_test.go#L1757
defer statements should only be cuddled with expressions on same variable (wsl)
|
|
[golangci] executor/linux/build_test.go#L342:
executor/linux/build_test.go#L342
only one cuddle assignment allowed before if statement (wsl)
|
|
[golangci] executor/linux/build_test.go#L863:
executor/linux/build_test.go#L863
only one cuddle assignment allowed before if statement (wsl)
|
|
[golangci] executor/linux/build_test.go#L202:
executor/linux/build_test.go#L202
ranges should only be cuddled with assignments used in the iteration (wsl)
|
|
[golangci] executor/linux/build_test.go#L1847:
executor/linux/build_test.go#L1847
if statements should only be cuddled with assignments used in the if statement itself (wsl)
|
|
[golangci] executor/linux/build_test.go#L1828:
executor/linux/build_test.go#L1828
ranges should only be cuddled with assignments used in the iteration (wsl)
|
|
[golangci] executor/linux/build_test.go#L322:
executor/linux/build_test.go#L322
defer statements should only be cuddled with expressions on same variable (wsl)
|
|
[golangci] executor/linux/build_test.go#L945:
executor/linux/build_test.go#L945
only one cuddle assignment allowed before range statement (wsl)
|
|
[golangci] mock/worker/executor.go#L38:
mock/worker/executor.go#L38
SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
|
|
[golangci] mock/worker/executor.go#L58:
mock/worker/executor.go#L58
SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
|
|
[golangci] cmd/vela-worker/exec.go#L31:
cmd/vela-worker/exec.go#L31
cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
|
|
[golangci] cmd/vela-worker/start.go#L61:
cmd/vela-worker/start.go#L61
return statements should not be cuddled if block has more than two lines (wsl)
|
|
[golangci] cmd/vela-worker/start.go#L70:
cmd/vela-worker/start.go#L70
expressions should not be cuddled with declarations or returns (wsl)
|
|
[golangci] cmd/vela-worker/start.go#L50:
cmd/vela-worker/start.go#L50
assignments should only be cuddled with other assignments (wsl)
|
|
[golangci] cmd/vela-worker/start.go#L54:
cmd/vela-worker/start.go#L54
expressions should not be cuddled with blocks (wsl)
|
|
[golangci] cmd/vela-worker/start.go#L57:
cmd/vela-worker/start.go#L57
assignments should only be cuddled with other assignments (wsl)
|
|
[golangci] cmd/vela-worker/exec.go#L30:
cmd/vela-worker/exec.go#L30
directive `//nolint:nilerr,funlen // ignore returning nil - don't want to crash worker` is unused for linter "nilerr" (nolintlint)
|