Skip to content
reviewdog

chore: upgrade server and fix tests #1781

Sign in to view logs

chore: upgrade server and fix tests

chore: upgrade server and fix tests #1781

Triggered via pull request May 16, 2024 18:43
@ecrupperecrupper
opened #580
chore/compiler-from-cli-context
Status Success
Total duration 2m 32s
Artifacts –

reviewdog.yml

on: pull_request
diff-review
2m 21s
diff-review
full-review
2m 21s
full-review
Fit to window
Zoom out
Zoom in

Annotations

20 errors
full-review: runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
full-review: runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
full-review: mock/docker/volume.go#L30
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: mock/docker/volume.go#L72
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: mock/docker/volume.go#L109
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
full-review: executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
full-review: executor/local/build_test.go#L515
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: runtime/kubernetes/mock.go#L143
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
diff-review: runtime/kubernetes/pod_tracker.go#L226
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
diff-review: mock/docker/container.go#L35
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: mock/docker/image.go#L31
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: mock/docker/plugin.go#L22
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: internal/service/upload_test.go#L166
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: internal/service/snapshot_test.go#L138
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: runtime/kubernetes/pod_tracker_test.go#L184
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: executor/local/build_test.go#L470
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: executor/local/build_test.go#L515
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)