fix error handling in runtime for outputs ctn

go-vela · Aug 12, 2024 · 39973b0 · 39973b0
1 parent 591883f
commit 39973b0
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/runtime/docker/container.go b/runtime/docker/container.go
@@ -7,7 +7,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"log"
 	"strings"
 
 	"github.com/docker/docker/api/types"
@@ -310,12 +309,12 @@ func (c *client) PollOutputsContainer(ctx context.Context, ctn *pipeline.Contain
 
 	responseExec, err := c.Docker.ContainerExecCreate(ctx, ctn.ID, execConfig)
 	if err != nil {
-		log.Fatal(err)
+		return nil, err
 	}
 
 	hijackedResponse, err := c.Docker.ContainerExecAttach(ctx, responseExec.ID, types.ExecStartCheck{})
 	if err != nil {
-		log.Fatal(err)
+		return nil, err
 	}
 
 	defer func() {