Skip to content

Commit

Permalink
chore(outputs): update comments (#595)
Browse files Browse the repository at this point in the history
  • Loading branch information
ecrupper authored Sep 12, 2024
1 parent c633ae4 commit 7a4997c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion executor/linux/opts.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,12 @@ func WithVersion(version string) Opt {
}
}

// WithOutputCtn sets the outputs container in the executor client for Linux.
func WithOutputCtn(ctn *pipeline.Container) Opt {
return func(c *client) error {
c.Logger.Trace("configuring output container in linux executor client")

// set the version in the client
// set the outputs container in the client
c.OutputCtn = ctn

return nil
Expand Down
2 changes: 1 addition & 1 deletion executor/linux/outputs.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (o *outputSvc) destroy(ctx context.Context, ctn *pipeline.Container) error
return nil
}

// update engine logger with secret metadata
// update engine logger with outputs metadata
//
// https://pkg.go.dev/github.com/sirupsen/logrus#Entry.WithField
logger := o.client.Logger.WithField("outputs", ctn.Name)
Expand Down
2 changes: 2 additions & 0 deletions runtime/kubernetes/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ func (c *client) RemoveContainer(ctx context.Context, ctn *pipeline.Container) e
return nil
}

// PollOutputsContainer captures the `cat` response for a given path in the Docker volume.
// This is a no-op for kubernetes. Pod environments cannot be dynamic.
func (c *client) PollOutputsContainer(ctx context.Context, ctn *pipeline.Container, path string) ([]byte, error) {
c.Logger.Tracef("no-op: removing container %s", ctn.ID)

Expand Down

0 comments on commit 7a4997c

Please sign in to comment.