Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(status): properly reflect worker status in db #525

Merged
merged 12 commits into from
Nov 1, 2023
Merged

fix(status): properly reflect worker status in db #525

merged 12 commits into from
Nov 1, 2023

Conversation

timhuynh94
Copy link
Contributor

@timhuynh94 timhuynh94 commented Oct 23, 2023 •
edited
Loading

Changes:

  • Utilize ping function from Server to check queue connection and set status appropriately.
  • Depends on Server 991

@timhuynh94 timhuynh94 marked this pull request as ready for review October 24, 2023 14:18
@timhuynh94 timhuynh94 requested a review from a team as a code owner October 24, 2023 14:18
cognifloyd
cognifloyd reviewed Oct 24, 2023
View reviewed changes
cmd/vela-worker/operate.go Outdated Show resolved Hide resolved
cmd/vela-worker/operate.go Outdated Show resolved Hide resolved
cmd/vela-worker/operate.go Outdated Show resolved Hide resolved
cmd/vela-worker/register.go Outdated Show resolved Hide resolved
cmd/vela-worker/register.go Outdated Show resolved Hide resolved
cmd/vela-worker/worker.go Outdated Show resolved Hide resolved
cmd/vela-worker/operate.go Outdated Show resolved Hide resolved
cognifloyd
cognifloyd previously approved these changes Oct 25, 2023
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #525 (46b7db4) into main (6494030) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files          69       69           
  Lines        5399     5399           
=======================================
  Hits         4497     4497           
  Misses        754      754           
  Partials      148      148

@wass3r wass3r changed the title Fix(status): worker status fix(status): properly reflect worker status in db Nov 1, 2023
wass3r
wass3r approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally with and without registration flow and seems to work well. thanks!

@timhuynh94 timhuynh94 requested review from plyr4 and removed request for plyr4 November 1, 2023 15:17
@timhuynh94 timhuynh94 merged commit 3249252 into main Nov 1, 2023
12 checks passed
@timhuynh94 timhuynh94 deleted the fix_bug_status branch November 1, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3r wass3r wass3r approved these changes

@cognifloyd cognifloyd cognifloyd approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timhuynh94 @wass3r @cognifloyd @plyr4