refactor: nested api/worker #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
=======================================
Coverage 80.71% 80.71%
=======================================
Files 69 69
Lines 3277 3277
=======================================
Hits 2645 2645
Misses 468 468
Partials 164 164 |
ecrupper
approved these changes
Mar 19, 2024
| w.RunningBuildIDs = append(w.RunningBuildIDs[:i], w.RunningBuildIDs[i+1:]...) | ||
| for i, v := range w.RunningBuilds { | ||
| if v.GetID() == item.Build.GetID() { | ||
| w.RunningBuilds = append(w.RunningBuilds[:i], w.RunningBuilds[i+1:]...) |
There was a problem hiding this comment.
If we upgrade to Go 1.22, we could use slices.Concat here.... just noting 😄
wass3rw3rk
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting on go-vela/server#997 and go-vela/sdk-go#298
also, imports for touched files follow the new pattern. see: go-vela/server#1077