Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build): update library build to API build and remove repo from executor #576

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

ecrupper
Copy link
Contributor

Ref: go-vela/server#1111

Build is nested now, so no need for repo in the executor.

@ecrupper ecrupper requested a review from a team as a code owner April 24, 2024 15:10
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 75.49020% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 57.96%. Comparing base (34d5b49) to head (701cd10).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   58.04%   57.96%   -0.08%     
==========================================
  Files         120      120              
  Lines        5031     4996      -35     
==========================================
- Hits         2920     2896      -24     
+ Misses       1909     1898      -11     
  Partials      202      202              
Files Coverage Δ
api/executor.go 0.00% <ø> (ø)
executor/linux/build.go 75.00% <100.00%> (+0.06%) ⬆️
executor/linux/linux.go 100.00% <ø> (ø)
executor/linux/opts.go 100.00% <100.00%> (ø)
executor/linux/stage.go 79.01% <100.00%> (ø)
executor/local/build.go 75.40% <100.00%> (ø)
executor/local/local.go 100.00% <ø> (ø)
executor/local/opts.go 95.65% <100.00%> (-0.35%) ⬇️
executor/local/service.go 93.44% <100.00%> (ø)
executor/local/stage.go 79.24% <100.00%> (ø)
... and 20 more

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 3d43998 into main Apr 24, 2024
10 of 14 checks passed
@ecrupper ecrupper deleted the refactor/nested-api/build branch April 24, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants