Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oidc provider #581

Merged
merged 8 commits into from
Jun 5, 2024
Merged

feat: oidc provider #581

merged 8 commits into from
Jun 5, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented May 30, 2024

worker implementation for go-vela/server#1120

@plyr4 plyr4 requested a review from a team as a code owner May 30, 2024 14:37
@plyr4 plyr4 changed the title feat/oidc provider feat: oidc provider May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.92%. Comparing base (bc88da1) to head (dfae0eb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   58.01%   57.92%   -0.09%     
==========================================
  Files         120      120              
  Lines        5002     5013      +11     
==========================================
+ Hits         2902     2904       +2     
- Misses       1898     1906       +8     
- Partials      202      203       +1     
Files Coverage Δ
executor/setup.go 100.00% <ø> (ø)
internal/step/environment.go 76.92% <100.00%> (+0.92%) ⬆️
executor/linux/step.go 76.00% <25.00%> (-4.00%) ⬇️

KellyMerrick
KellyMerrick previously approved these changes May 30, 2024
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing

executor/linux/step.go Outdated Show resolved Hide resolved
@ecrupper ecrupper merged commit 63c4ff6 into main Jun 5, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the feat/oidc-provider branch June 5, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants