Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: container outputs and dynamic environments #591

Merged
merged 21 commits into from
Sep 11, 2024

correct pull policy and update secret masking

1dda99b
Select commit
Loading
Failed to load commit list.
Merged

feat: container outputs and dynamic environments #591

correct pull policy and update secret masking
1dda99b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 13, 2024 in 1s

58.03% (target 90.00%)

View this Pull Request on Codecov

58.03% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 59.47137% with 92 lines in your changes missing coverage. Please review.

Project coverage is 58.03%. Comparing base (dd70412) to head (1dda99b).

Files Patch % Lines
executor/linux/build.go 35.13% 15 Missing and 9 partials ⚠️
runtime/docker/container.go 51.51% 9 Missing and 7 partials ⚠️
executor/linux/stage.go 41.17% 6 Missing and 4 partials ⚠️
cmd/vela-worker/run.go 0.00% 8 Missing ⚠️
executor/linux/outputs.go 87.69% 4 Missing and 4 partials ⚠️
executor/linux/step.go 66.66% 3 Missing and 3 partials ⚠️
cmd/vela-worker/exec.go 0.00% 5 Missing ⚠️
runtime/kubernetes/container.go 28.57% 4 Missing and 1 partial ⚠️
internal/image/image.go 73.33% 2 Missing and 2 partials ⚠️
runtime/docker/image.go 0.00% 3 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   57.91%   58.03%   +0.11%     
==========================================
  Files         120      121       +1     
  Lines        5014     5164     +150     
==========================================
+ Hits         2904     2997      +93     
- Misses       1907     1942      +35     
- Partials      203      225      +22
Files Coverage Δ
executor/linux/linux.go 100.00% <100.00%> (ø)
executor/linux/opts.go 100.00% <100.00%> (ø)
executor/linux/secret.go 73.50% <100.00%> (ø)
executor/local/build.go 75.66% <100.00%> (ø)
executor/local/stage.go 79.62% <100.00%> (ø)
executor/setup.go 100.00% <100.00%> (ø)
executor/linux/service.go 77.24% <75.00%> (-0.14%) ⬇️
internal/image/image.go 85.71% <73.33%> (+1.71%) ⬆️
runtime/docker/image.go 65.71% <0.00%> (ø)
cmd/vela-worker/exec.go 0.00% <0.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

View more details on Codecov