Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: container outputs and dynamic environments #591

Merged
merged 21 commits into from
Sep 11, 2024

Merge branch 'main' into feat/outputs-ctn

33dbda9
Select commit
Loading
Failed to load commit list.
Merged

feat: container outputs and dynamic environments #591

Merge branch 'main' into feat/outputs-ctn
33dbda9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 26, 2024 in 0s

57.60% (target 90.00%)

View this Pull Request on Codecov

57.60% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 60.27397% with 87 lines in your changes missing coverage. Please review.

Project coverage is 57.60%. Comparing base (66403e5) to head (33dbda9).

Files Patch % Lines
executor/linux/build.go 33.33% 14 Missing and 8 partials ⚠️
runtime/docker/container.go 51.51% 9 Missing and 7 partials ⚠️
executor/linux/stage.go 37.50% 6 Missing and 4 partials ⚠️
cmd/vela-worker/run.go 0.00% 8 Missing ⚠️
executor/linux/outputs.go 87.69% 4 Missing and 4 partials ⚠️
executor/linux/step.go 66.66% 3 Missing and 3 partials ⚠️
runtime/kubernetes/container.go 28.57% 4 Missing and 1 partial ⚠️
internal/image/image.go 73.33% 2 Missing and 2 partials ⚠️
runtime/docker/image.go 0.00% 3 Missing and 1 partial ⚠️
cmd/vela-worker/exec.go 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   57.44%   57.60%   +0.16%     
==========================================
  Files         120      121       +1     
  Lines        5055     5204     +149     
==========================================
+ Hits         2904     2998      +94     
- Misses       1948     1982      +34     
- Partials      203      224      +21
Files Coverage Δ
executor/linux/linux.go 100.00% <100.00%> (ø)
executor/linux/opts.go 100.00% <100.00%> (ø)
executor/linux/secret.go 73.50% <100.00%> (ø)
executor/setup.go 100.00% <100.00%> (ø)
internal/step/environment.go 78.57% <100.00%> (+1.64%) ⬆️
cmd/vela-worker/exec.go 0.00% <0.00%> (ø)
executor/linux/service.go 77.24% <75.00%> (-0.14%) ⬇️
internal/image/image.go 85.71% <73.33%> (+1.71%) ⬆️
runtime/docker/image.go 65.71% <0.00%> (ø)
runtime/kubernetes/container.go 77.93% <28.57%> (-1.79%) ⬇️
... and 6 more

... and 1 file with indirect coverage changes

View more details on Codecov