Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use go 1.23 and fix validate #597

Merged
merged 1 commit into from
Sep 19, 2024

chore: use go 1.23 and fix validate

dfd1e9e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore: use go 1.23 and fix validate #597

chore: use go 1.23 and fix validate
dfd1e9e
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci failed Sep 19, 2024 in 0s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (41)

runtime/kubernetes/mock.go|143 col 53| Error return value of (k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler is not checked (errcheck)
runtime/kubernetes/pod_tracker.go|226 col 40| Error return value of (k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler is not checked (errcheck)
cmd/vela-worker/exec.go|31 col 1| cyclomatic complexity 31 of func (*Worker).exec is high (> 30) (gocyclo)
mock/docker/container.go|35 col 44| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
mock/docker/swarm.go|22 col 42| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
mock/docker/system.go|24 col 35| unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
internal/service/snapshot_test.go|138 col 25| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
internal/service/upload_test.go|166 col 25| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
runtime/kubernetes/pod_tracker_test.go|184 col 25| unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
executor/local/build_test.go|470 col 19| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
executor/local/build_test.go|515 col 19| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
executor/linux/build_test.go|1100 col 19| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
executor/linux/secret.go|209 col 37| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
executor/linux/secret.go|226 col 37| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
executor/linux/secret.go|243 col 37| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
mock/worker/executor.go|38 col 13| SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
mock/worker/executor.go|58 col 11| SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
cmd/vela-worker/start.go|57 col 4| assignments should only be cuddled with other assignments (wsl)
cmd/vela-worker/start.go|58 col 4| only one cuddle assignment allowed before if statement (wsl)
cmd/vela-worker/start.go|61 col 4| return statements should not be cuddled if block has more than two lines (wsl)
cmd/vela-worker/start.go|70 col 3| expressions should not be cuddled with declarations or returns (wsl)
cmd/vela-worker/start.go|71 col 3| if statements should only be cuddled with assignments (wsl)
cmd/vela-worker/start.go|50 col 4| assignments should only be cuddled with other assignments (wsl)
cmd/vela-worker/start.go|51 col 4| only one cuddle assignment allowed before if statement (wsl)
cmd/vela-worker/start.go|54 col 4| expressions should not be cuddled with blocks (wsl)
executor/linux/build_test.go|394 col 4| if statements should only be cuddled with assignments (wsl)
executor/linux/build_test.go|1503 col 5| only one cuddle assignment allowed before if statement (wsl)
executor/linux/build_test.go|1553 col 5| if statements should only be cuddled with assignments (wsl)
executor/linux/build_test.go|605 col 4| defer statements should only be cuddled with expressions on same variable (wsl)
executor/linux/build_test.go|384 col 4| ranges should only be cuddled with assignments used in the iteration (wsl)
executor/linux/build_test.go|1483 col 4| defer statements should only be cuddled with expressions on same variable (wsl)
executor/linux/build_test.go|1595 col 4| ranges should only be cuddled with assignments used in the iteration (wsl)
executor/linux/build_test.go|945 col 6| only one cuddle assignment allowed before range statement (wsl)
executor/linux/build_test.go|1757 col 4| defer statements should only be cuddled with expressions on same variable (wsl)
executor/linux/build_test.go|1828 col 4| ranges should only be cuddled with assignments used in the iteration (wsl)
executor/linux/build_test.go|207 col 6| if statements should only be cuddled with assignments used in the if statement itself (wsl)
executor/linux/build_test.go|697 col 6| if statements should only be cuddled with assignments used in the if statement itself (wsl)
executor/linux/build_test.go|1600 col 6| if statements should only be cuddled with assignments used in the if statement itself (wsl)
internal/context/context_test.go|148 col 4| assignments should only be cuddled with other assignments (wsl)
runtime/kubernetes/pod_tracker_test.go|373 col 4| expressions should not be cuddled with blocks (wsl)
cmd/vela-worker/exec.go|30 col 1| directive //nolint:nilerr,funlen // ignore returning nil - don't want to crash worker is unused for linter "nilerr" (nolintlint)

Filtered Findings (0)

Annotations

Check failure on line 143 in runtime/kubernetes/mock.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/mock.go#L143

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
Raw output
runtime/kubernetes/mock.go:143:53: Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
	c.PodTracker.podInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
	                                                   ^

Check failure on line 226 in runtime/kubernetes/pod_tracker.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/pod_tracker.go#L226

Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
Raw output
runtime/kubernetes/pod_tracker.go:226:40: Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
	podInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
	                                      ^

Check failure on line 31 in cmd/vela-worker/exec.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/exec.go#L31

cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
Raw output
cmd/vela-worker/exec.go:31:1: cyclomatic complexity 31 of func `(*Worker).exec` is high (> 30) (gocyclo)
func (w *Worker) exec(index int, config *api.Worker) error {
^

Check failure on line 35 in mock/docker/container.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] mock/docker/container.go#L35

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
mock/docker/container.go:35:44: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (c *ContainerService) ContainerAttach(ctx context.Context, ctn string, options container.AttachOptions) (types.HijackedResponse, error) {
                                           ^

Check failure on line 22 in mock/docker/swarm.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] mock/docker/swarm.go#L22

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
mock/docker/swarm.go:22:42: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (s *SwarmService) SwarmGetUnlockKey(ctx context.Context) (types.SwarmUnlockKeyResponse, error) {
                                         ^

Check failure on line 24 in mock/docker/system.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] mock/docker/system.go#L24

unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
mock/docker/system.go:24:35: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func (s *SystemService) DiskUsage(ctx context.Context, opts types.DiskUsageOptions) (types.DiskUsage, error) {
                                  ^

Check failure on line 138 in internal/service/snapshot_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/service/snapshot_test.go#L138

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
internal/service/snapshot_test.go:138:25: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
		t.Run(test.name, func(t *testing.T) {
		                      ^

Check failure on line 166 in internal/service/upload_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/service/upload_test.go#L166

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
internal/service/upload_test.go:166:25: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
		t.Run(test.name, func(t *testing.T) {
		                      ^

Check failure on line 184 in runtime/kubernetes/pod_tracker_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] runtime/kubernetes/pod_tracker_test.go#L184

unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
runtime/kubernetes/pod_tracker_test.go:184:25: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
		t.Run(test.name, func(t *testing.T) {
		                      ^

Check failure on line 470 in executor/local/build_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/local/build_test.go#L470

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/local/build_test.go:470:19: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
			planFunc: func(c *client) planFuncType {
			               ^

Check failure on line 515 in executor/local/build_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/local/build_test.go#L515

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/local/build_test.go:515:19: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
			planFunc: func(c *client) planFuncType {
			               ^

Check failure on line 1100 in executor/linux/build_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/build_test.go#L1100

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
executor/linux/build_test.go:1100:19: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
			planFunc: func(c *client) planFuncType {
			               ^

Check failure on line 209 in executor/linux/secret.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/secret.go#L209

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output
executor/linux/secret.go:209:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
			                                 ^

Check failure on line 226 in executor/linux/secret.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/secret.go#L226

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output
executor/linux/secret.go:226:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
			                                 ^

Check failure on line 243 in executor/linux/secret.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] executor/linux/secret.go#L243

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Raw output
executor/linux/secret.go:243:37: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
			return nil, fmt.Errorf("%s: %w", ErrUnableToRetrieve, err)
			                                 ^

Check failure on line 38 in mock/worker/executor.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] mock/worker/executor.go#L38

SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
mock/worker/executor.go:38:13: SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
	var body []library.Executor
	           ^

Check failure on line 58 in mock/worker/executor.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] mock/worker/executor.go#L58

SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
Raw output
mock/worker/executor.go:58:11: SA1019: library.Executor is deprecated: use Executor from github.com/go-vela/server/api/types instead. (staticcheck)
	var body library.Executor
	         ^

Check failure on line 57 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L57

assignments should only be cuddled with other assignments (wsl)
Raw output
cmd/vela-worker/start.go:57:4: assignments should only be cuddled with other assignments (wsl)
			err := server.Shutdown(ctx)
			^

Check failure on line 58 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L58

only one cuddle assignment allowed before if statement (wsl)
Raw output
cmd/vela-worker/start.go:58:4: only one cuddle assignment allowed before if statement (wsl)
			if err != nil {
			^

Check failure on line 61 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L61

return statements should not be cuddled if block has more than two lines (wsl)
Raw output
cmd/vela-worker/start.go:61:4: return statements should not be cuddled if block has more than two lines (wsl)
			return gctx.Err()
			^

Check failure on line 70 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L70

expressions should not be cuddled with declarations or returns (wsl)
Raw output
cmd/vela-worker/start.go:70:3: expressions should not be cuddled with declarations or returns (wsl)
		logrus.Info("starting worker server")
		^

Check failure on line 71 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L71

if statements should only be cuddled with assignments (wsl)
Raw output
cmd/vela-worker/start.go:71:3: if statements should only be cuddled with assignments (wsl)
		if tlsCfg != nil {
		^

Check failure on line 50 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L50

assignments should only be cuddled with other assignments (wsl)
Raw output
cmd/vela-worker/start.go:50:4: assignments should only be cuddled with other assignments (wsl)
			err := server.Shutdown(ctx)
			^

Check failure on line 51 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L51

only one cuddle assignment allowed before if statement (wsl)
Raw output
cmd/vela-worker/start.go:51:4: only one cuddle assignment allowed before if statement (wsl)
			if err != nil {
			^

Check failure on line 54 in cmd/vela-worker/start.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-worker/start.go#L54

expressions should not be cuddled with blocks (wsl)
Raw output
cmd/vela-worker/start.go:54:4: expressions should not be cuddled with blocks (wsl)
			done()
			^