Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove types dependency #610

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner October 22, 2024 14:27
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 20 lines in your changes missing coverage. Please review.

Project coverage is 62.07%. Comparing base (0e10f28) to head (d5e48da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/executor.go 0.00% 6 Missing ⚠️
api/build.go 0.00% 2 Missing ⚠️
cmd/vela-worker/exec.go 0.00% 2 Missing ⚠️
mock/worker/build.go 0.00% 2 Missing ⚠️
api/pipeline.go 0.00% 1 Missing ⚠️
api/repo.go 0.00% 1 Missing ⚠️
cmd/vela-worker/register.go 0.00% 1 Missing ⚠️
executor/linux/step.go 0.00% 1 Missing ⚠️
mock/worker/executor.go 0.00% 1 Missing ⚠️
mock/worker/pipeline.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   62.21%   62.07%   -0.14%     
==========================================
  Files         121      121              
  Lines        8214     8166      -48     
==========================================
- Hits         5110     5069      -41     
+ Misses       2878     2871       -7     
  Partials      226      226              
Files with missing lines Coverage Δ
cmd/vela-worker/operate.go 0.00% <ø> (ø)
cmd/vela-worker/run.go 0.00% <ø> (ø)
executor/executor.go 100.00% <ø> (ø)
executor/linux/api.go 9.75% <ø> (ø)
executor/linux/build.go 76.44% <100.00%> (-0.21%) ⬇️
executor/linux/driver.go 100.00% <ø> (ø)
executor/linux/secret.go 73.22% <ø> (+0.38%) ⬆️
executor/linux/service.go 79.15% <ø> (+0.20%) ⬆️
executor/linux/stage.go 77.64% <ø> (-0.26%) ⬇️
executor/local/api.go 9.75% <ø> (ø)
... and 40 more

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 3db6801 into main Oct 22, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the refactor/nested-api/log-and-misc branch October 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants