Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret): update env values for secret origin ctn #615

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Nov 9, 2024

We've added a couple features to the worker (OIDC and Outputs), yet we didn't update the secret container config to account for these.

These are both very important when considering masked outputs and Vault OIDC policies.

@ecrupper ecrupper requested a review from a team as a code owner November 9, 2024 14:18
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.93%. Comparing base (402d3d0) to head (98e16b8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
executor/linux/build.go 29.41% 11 Missing and 1 partial ⚠️
executor/linux/secret.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   62.02%   61.93%   -0.10%     
==========================================
  Files         121      121              
  Lines        8173     8193      +20     
==========================================
+ Hits         5069     5074       +5     
- Misses       2878     2891      +13     
- Partials      226      228       +2     
Files with missing lines Coverage Δ
executor/linux/secret.go 72.54% <57.14%> (-0.69%) ⬇️
executor/linux/build.go 75.21% <29.41%> (-1.23%) ⬇️

Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ecrupper ecrupper merged commit 3f3b424 into main Nov 11, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/outputs-env-for-secrets branch November 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants