Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq4: do not panic b/c of invalid connection attempts #66

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented Jan 21, 2020

Updates #56.

@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #66 into master will increase coverage by 3.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   57.68%   61.53%   +3.84%     
==========================================
  Files          26       26              
  Lines        1933     1934       +1     
==========================================
+ Hits         1115     1190      +75     
+ Misses        726      660      -66     
+ Partials       92       84       -8
Impacted Files Coverage Δ
socket.go 82.06% <100%> (+3.37%) ⬆️
conn.go 58.94% <100%> (+4.21%) ⬆️
pub.go 72.43% <0%> (+2.16%) ⬆️
router.go 77.77% <0%> (+3.17%) ⬆️
pair.go 73.91% <0%> (+8.69%) ⬆️
sub.go 78.46% <0%> (+9.23%) ⬆️
socket_types.go 92.45% <0%> (+9.43%) ⬆️
req.go 75% <0%> (+14.28%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28043d4...7ac6ef9. Read the comment docs.

This CL also makes sure we exercize invalid connection attempts and
still end up with a valid, non-corrupted, socket state.

Updates go-zeromq#56.
@sbinet sbinet merged commit 7ac6ef9 into go-zeromq:master Jan 21, 2020
@sbinet sbinet deleted the issue-56 branch January 21, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants