Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use doc.IsPredeclared() and token.IsKeyword() for codegen.fixReservedGo() #3599

Merged
merged 5 commits into from
Oct 13, 2024

Conversation

tchssk
Copy link
Member

@tchssk tchssk commented Oct 4, 2024

No description provided.

@tchssk tchssk force-pushed the codegen-fixreservedgo-ispredeclared branch from 4ac46cc to 8e62659 Compare October 4, 2024 15:40
@tchssk tchssk changed the title Use doc.IsPredeclared() for codegen.fixReservedGo() Use doc.IsPredeclared() and token.IsKeyword() for codegen.fixReservedGo() Oct 4, 2024
@tchssk tchssk marked this pull request as ready for review October 4, 2024 15:53
Copy link
Member

@raphael raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great! Do we also need to consider the std lib package names separately?

@tchssk
Copy link
Member Author

tchssk commented Oct 11, 2024

Oops! I added a condition.

@raphael
Copy link
Member

raphael commented Oct 13, 2024

Perfect, thank you!

@raphael raphael merged commit 6de544f into goadesign:v3 Oct 13, 2024
9 checks passed
@tchssk tchssk deleted the codegen-fixreservedgo-ispredeclared branch October 13, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants