Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images with PHP 8.2 support. #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ronaldtebrake
Copy link
Contributor

@ronaldtebrake ronaldtebrake commented Dec 2, 2024

Added new drupal10 images for PHP 8.2.

Based on #39 i've added new images for, ci & php both with and without rdkafka extension. Therefor 4 new folders.

  1. I've copied from the existing 8.1 extension, verified that the drupal image exists and didn't update anything other than php version (in the future we can make it the drupal 10.3 image).
  2. As goalgorilla/open_social_dev now ships with "palantirnet/drupal-rector": "^0.20.3", I've removed that here (it's already a dev requirement)
  3. I've had to update xdebug, so I've chosen a compatible version with PHP 8.2 and PHP 8.3 (https://xdebug.org/docs/compat)

…, PHP and with without rdkafka as extension.

In #39 we've added rdkafka, which created some new images in duplicate folders.
Considering we haven't gotten around to overhauling our docker images, I've ensured we still have the same
amount of flexibility for PHP 8.2 even if it feels a bit silly (#39 (comment))
This version is also already PHP 8.3 compatible as per https://xdebug.org/docs/compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants