-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wine stability improvements #1769
base: master
Are you sure you want to change the base?
Conversation
n.b. holding this PR as we're allegedly seeing some issues with MinHook with certain plugins (including Simple Tweaks). See #linux-and-dev channel in the Dalamud Discord. We're also looking at how best to handle |
Indeed The Reloaded issue does indeed need some more looking into, in any case something is not behaving as it should. If this change does also create issues on Windows that might also be worth investigating, since that is a bit easier to debug. |
We definitely can't "just" turn it off, we'll have to have some kind of migration plan. Either way it's a hard sell to devs, we'll talk about it internally, it's good to have the option for now though. |
9687bcf
to
958d1df
Compare
I dropped the hook changes part for now... |
is the thinking that the problems those changes addressed are now fixed in a different way, or will be fixed with Dawntrail, or something else? |
I believe it to be an issue somewhere inside reloaded for stacked hooks; am currently trying to come up with a better solution. |
This uses MinHook for the Addon Hooks, as there seems to be a race with Reloaded somewhere that leads to execution of random code after a while.
Also makes
DALAMUD_LEGACY_CORRUPTED_STATE_EXCEPTION
configurable, which is highly undesirable to have enabled with Wine, as this can mask underlying issues and lead to random crashes as well.