Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take ImGuiScene into Dalamud #1923

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Soreepeong
Copy link
Contributor

@Soreepeong Soreepeong commented Jul 12, 2024

Smaller part of #1542.

  • Nothing in Dalamud.Interface.ImGuiBackend should be visible to plugins. They must be internal.
  • No special ReShade handling will be needed. Dalamud would receive DirectX objects behind ReShade.
  • External windows will support transparency.
  • Added --debug-directx to enable D3D11/DXGI debugging.

Probably needs more testing with ReShade installed, though.

@Soreepeong Soreepeong requested a review from a team as a code owner July 12, 2024 08:46
@Soreepeong
Copy link
Contributor Author

On 3c84b9c: seems that reshade recently changed IDXGISwapChain wrapper class layout, so previous 0x10 would have become 0x08. crosire/reshade@aedef46#diff-963981c848bbb3106d4ee73bfdf53d556bd1bacfe901680995c7eb5eeb4a600d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant