Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IServiceScope.CreateAsync
to never return null, and instead store the exception in the returned Task.ServiceScope
to useConcurrentDictionary<Type, Task<object>>
to manage created objects.IDalamudPluginInterface.CreateAsync
to offer an alternative avoiding using.Wait
.IDalamudPluginInterface.Create
will work as it always did; only a small note has been added that describes what happens on failure, and its actual behavior did not change.IDalamudPluginInterface.InjectAsync
for same reasons.