fix: Don't use a hook for ClientState#TerritoryType

[KazWolfe]

• We can just read this from the game data.

Added as its own method because unsafe getters are ugly af.

[goaaats]

Why specifically, is it just because this isn't set when injecting while the game is running? I usually don't like this type of change as it makes it harder to reason about what order things are done in. i.e. the field we are reading from might be set after the hook is fired, so now subscribers that read from the field in the event won't have the correct territory.

[Haselnussbomber]

There will certainly be confusion as to why the TerritoryType id doesn't match the id that the TerritoryChanged event delivers:
The function that's being hooked for SetupTerritoryTypeDetour is Client::Game::Event::EventFramework.SetTerritoryTypeId, called just a bit after Client::Game::GameMain.StartTerritoryTransition. All this happens inside a function that's called in ProcessPacketInitZone.
GameMain sets CurrentTerritoryTypeId to 0 in there, and the id from the packet to TransitionTerritoryTypeId.
CurrentTerritoryTypeId is set to what TransitionTerritoryTypeId was when the transition is done - inside Client::Game::GameMain.Update.
So there will be some time between when the event is fired and when CurrentTerritoryTypeId is updated.

[goaaats]

I think that is a deal-breaker until we decouple that and also have two IDs for current and pending territory, if that is even necessary. I doubt anyone has ever needed it and our API might not need to support it, just seems confusing to people.
We should set the ID and fire the event once we know that we are definitely going to a territory (and loading can't be cancelled anymore). I think that used to be the case.

[Haselnussbomber]

I just ran into this by accident in my plugin, actually.
Instead of using ClientState.IsPvP, I was using GameMain.IsInPvPArea() (which reads from GameMain.CurrentTerritoryTypeRow, that is set right after GameMain.CurrentTerritoryTypeId), and it returning false a lot later than the event ClientState.TerritoryChanged was fired. Here the log that shows this:

03:39:00.085 | OnTerritoryChanged: 250
(EnterPvP here, I was not subscribed to it)
03:39:00.897 | IsInPvPArea: True
03:39:12.290 | OnTerritoryChanged: 339
03:39:12.291 | OnLeavePvP
03:39:14.493 | IsInPvPArea: False

[wolfcomp]

IMO if this has a more correct return type than the hook this should be the defacto way to get the territory type.

[goaaats]

More correct is not always == a good API, especially if it breaks existing assumptions.

[wolfcomp]

This isn't about following API properties since we are explicitly having to deal with how SE codes the systems so if this follows better to how the system works in SE code this is the correct way and what is currently breaks the assumptions about the system.