Merge pull request #201 from tommadness/master

Add duplicate protection to linter
goatcorp · Jul 9, 2024 · bc4d4c0 · bc4d4c0
2 parents 01f2ed3 + 92e2a31
commit bc4d4c0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 93 deletions.
diff --git a/.github/workflows/validate-json.yml b/.github/workflows/validate-json.yml
@@ -19,9 +19,15 @@ jobs:
           # Check if the file exists
           if [ -f ./UIRes/bannedplugin.json ]; then
             # Validate the JSON file
-            cat ./UIRes/bannedplugin.json | jq . > /dev/null
+            DUPES=$(cat ./UIRes/bannedplugin.json | jq 'group_by(.Name)[] | {Name: .[0].Name, length: length} | select(.length > 1)')
+            echo "${#DUPES}"
+            echo "${DUPES}"
             if [ $? -eq 0 ]; then
               echo "JSON file is valid"
+              if [ "${#DUPES}" -gt 0 ]; then
+                echo "Duplicate entries found. Please correct them. ${DUPES}"
+                exit 1
+              fi
             else
               echo "JSON file is invalid"
               exit 1

diff --git a/UIRes/bannedplugin.json b/UIRes/bannedplugin.json
@@ -82,14 +82,6 @@
     "AssemblyVersion": "1.2.0",
     "Reason": "Requested by Ava. Download the new/current version."
   },
-  {
-    "Name": "JobBars",
-    "AssemblyVersion": "1.2.1.0"
-  },
-  {
-    "Name": "SoundSetter",
-    "AssemblyVersion": "1.5.5.0"
-  },
   {
     "Name": "EngageTimer",
     "AssemblyVersion": "2.2.0.1"
@@ -106,10 +98,6 @@
     "Name": "OopsAllLalafells",
     "AssemblyVersion": "1.3.0"
   },
-  {
-    "Name": "EnemyListDebuffs",
-    "AssemblyVersion": "0.3.3.0"
-  },
   {
     "Name": "EB40F8A76F57D9EFD8F751229F0163BE5C64B2E376B329622527A0B04CDAE5E6",
     "AssemblyVersion": "0.4.0.7"
@@ -134,38 +122,14 @@
     "Name": "554EE42A86CE631574439D2BD827F8C0685C5F94DA760D600EFB6615B43ACC1F",
     "AssemblyVersion": "2.0.3.2"
   },
-  {
-    "Name": "GatherBuddy",
-    "AssemblyVersion": "3.0.5.1"
-  },
-  {
-    "Name": "MOAction",
-    "AssemblyVersion": "4.2.5"
-  },
-  {
-    "Name": "HUDManager",
-    "AssemblyVersion": "2.5.6.3"
-  },
-  {
-    "Name": "SimpleTweaksPlugin",
-    "AssemblyVersion": "1.8.3.0"
-  },
   {
     "Name": "PartyListLayout",
     "AssemblyVersion": "0.3.4.0"
   },
-  {
-    "Name": "NamePlateDebuffs",
-    "AssemblyVersion": "0.5.6.0"
-  },
   {
     "Name": "Dalamud.FindAnything",
     "AssemblyVersion": "1.0.1.7"
   },
-  {
-    "Name": "Compass",
-    "AssemblyVersion": "1.20.1"
-  },
   {
     "Name": "ARealmRecorded",
     "AssemblyVersion": "0.4.1.0"
@@ -239,16 +203,6 @@
     "AssemblyVersion": "0.9.29",
     "Reason": "Loading/Updating issue from 0.9.29 to next versions"
   },
-  {
-    "Name": "DailyDuty",
-    "AssemblyVersion": "3.2.4.2",
-    "Reason": "Requires Dalamud Assets that aren't released yet"
-  },
-  {
-    "Name": "InventoryTools",
-    "AssemblyVersion": "1.3.1.0",
-    "Reason": "Please update this plugin to use it."
-  },
   {
     "Name": "GatherBuddy",
     "AssemblyVersion": "3.2.1.5",
@@ -259,16 +213,6 @@
     "AssemblyVersion": "1.1.0.2",
     "Reason": "Please update this plugin to use it."
   },
-  {
-    "Name": "CrossUp",
-    "AssemblyVersion": "0.3.3.4",
-    "Reason": "This plugin is outdated and will need to be updated its author."
-  },
-  {
-    "Name": "CrossUp",
-    "AssemblyVersion": "1.7.0.0",
-    "Reason": "This plugin is outdated and will need to be updated its author."
-  },
   {
     "Name": "CrossUp",
     "AssemblyVersion": "1.7.0.1",
@@ -284,11 +228,6 @@
     "AssemblyVersion": "1.1.1.3",
     "Reason": "This plugin is depricated, and is now a SimpleTweak."
   },
-  {
-    "Name": "SubmarineTracker",
-    "AssemblyVersion": "0.0.7.0",
-    "Reason": "Crash on startup."
-  },
   {
     "Name": "SimpleTweaksPlugin",
     "AssemblyVersion": "1.8.7.0"
@@ -297,20 +236,11 @@
     "Name": "AutoMammet",
     "AssemblyVersion": "1.3.0.0"
   },
-  {
-    "Name": "CrossUp",
-    "AssemblyVersion": "0.4.3.2",
-    "Reason": "This plugin is outdated and will need to be updated by its author."
-  },
   {
     "Name": "Visibility",
     "AssemblyVersion": "1.1.4.8",
     "Reason": "Not yet working with Patch 6.4 (CS)."
   },
-  {
-    "Name": "DelvUI",
-    "AssemblyVersion": "1.6.2.1"
-  },
   {
     "Name": "EnemyListDebuffs",
     "AssemblyVersion": "0.3.7.0",
@@ -320,11 +250,6 @@
     "Name": "ChatBubbles",
     "AssemblyVersion": "2.1.3.1"
   },
-  {
-    "Name": "AD93155F9CE43A9475439AF6DC639023A797197EE22A4F3FE3D2F9D0B996DFD9",
-    "AssemblyVersion": "0.7.0.15",
-    "Reason": "Crashes with Patch 6.4"
-  },
   {
     "Name": "2128B3DC12F26BFE22CA0B14171DCE7448016F9BACBED0DC2526B57483FAB743",
     "AssemblyVersion": "0.1.1.5",
@@ -346,10 +271,6 @@
     "Name": "HighFpsPhysicsPlugin",
     "AssemblyVersion": "7.1.0.0"
   },
-  {
-    "Name": "BetterMountRoulette",
-    "AssemblyVersion": "1.2.0.11"
-  },
   {
     "Name": "Dalamud.LoadingImage",
     "AssemblyVersion": "1.0.0.10"
@@ -436,19 +357,10 @@
     "Name": "92D0F7F3C97C65BD0106631009402C8C04AA5F4E112B5586635CB8DD1033A296",
     "AssemblyVersion": "0.0.1.7"
   },
-  {
-    "Name": "CrossUp",
-    "AssemblyVersion": "1.0.0.0"
-  },
   {
     "Name": "PriceInsight",
     "AssemblyVersion": "2.5.0.0"
   },
-  {
-    "Name": "CurrencyTracker",
-    "AssemblyVersion": "1.1.1.2",
-    "Reason": "crashes when UI open for ten minutes"
-  },
   {
     "Name": "B778B7FD16CA72AC1EA7A0F28A099D46948B4A732B6F08F12E4C5861041FE87B",
     "AssemblyVersion": "1.2.0.3"
@@ -457,10 +369,6 @@
     "Name": "BetterMountRoulette",
     "AssemblyVersion": "1.2.0.13"
   },
-  {
-    "Name": "AD93155F9CE43A9475439AF6DC639023A797197EE22A4F3FE3D2F9D0B996DFD9",
-    "AssemblyVersion": "0.8.1.0"
-  },
   {
     "Name": "Honorific",
     "AssemblyVersion": "1.2.2.0"