Merge branch 'goatcorp:main' into main

.github/workflows/pacnag.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: reiichi001/PAC-Nag@a76ed0ac31a9528f5dc9bc4e591fc6aca85ecd4a
+      - uses: reiichi001/PAC-Nag@266d6766e806ccd29e1f1ec2a5fbbbc030b43b8d
         with:
           token: ${{secrets.GITHUB_TOKEN}}
           discord_webhook: ${{secrets.PAC_DISCORD_WEBHOOK}}

.github/workflows/pull_request_dispatch.yml

@@ -28,13 +28,36 @@ jobs:
         status: in_progress
         details_url: "https://github.com/goatcorp/DalamudPluginsD17/actions/runs/${{ github.run_id }}"
 
-    - name: Checkout manifests
+    - name: Setup Difftastic
+      run: |
+        wget https://github.com/Wilfred/difftastic/releases/latest/download/difft-x86_64-unknown-linux-gnu.tar.gz
+        tar -xzf difft-x86_64-unknown-linux-gnu.tar.gz
+        sudo mv difft /usr/local/bin/difft
+        sudo chmod +x /usr/local/bin/difft
+        difft --version
+
+    - name: Setup terminal-to-html
+      run: |
+        wget https://github.com/buildkite/terminal-to-html/releases/download/v3.14.0/terminal-to-html-3.14.0-linux-amd64.gz
+        gunzip terminal-to-html-3.14.0-linux-amd64.gz
+        sudo chmod +x terminal-to-html-3.14.0-linux-amd64
+        sudo mv terminal-to-html-3.14.0-linux-amd64 /usr/local/bin/terminal-to-html
+        terminal-to-html --version
+
+    - name: Checkout manifests from incoming PR
       uses: actions/checkout@v3
       with:
         repository: goatcorp/DalamudPluginsD17
         path: manifests
         ref: ${{ github.event.client_payload.ref }}
 
+    - name: Checkout manifests from master
+      uses: actions/checkout@v3
+      with:
+        repository: goatcorp/DalamudPluginsD17
+        path: manifests-master
+        ref: main
+
     - name: Checkout Plogon
       uses: actions/checkout@v3
       with:
@@ -84,6 +107,7 @@ jobs:
         --work-folder="${{ github.workspace }}/work" \
         --static-folder="${{ github.workspace }}/Plogon/Plogon/static" \
         --artifact-folder="${{ github.workspace }}/artifacts" \
+        --build-overrides-file="${{ github.workspace }}/manifests-master/overrides.toml" \
         --ci --mode=PullRequest
 
         cat $GITHUB_STEP_SUMMARY

.github/workflows/push.yml

@@ -17,6 +17,14 @@ jobs:
         path: manifests
         ref: ${{ github.event.pull_request.head.sha }}
 
+    - name: Setup Difftastic
+      run: |
+        wget https://github.com/Wilfred/difftastic/releases/latest/download/difft-x86_64-unknown-linux-gnu.tar.gz
+        tar -xzf difft-x86_64-unknown-linux-gnu.tar.gz
+        sudo mv difft /usr/local/bin/difft
+        sudo chmod +x /usr/local/bin/difft
+        difft --version
+
     - name: Checkout Plogon
       uses: actions/checkout@v3
       with:
@@ -51,17 +59,22 @@ jobs:
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }}
+        PAC_DISCORD_WEBHOOK: ${{ secrets.PAC_DISCORD_WEBHOOK }}
         EXTENDED_IMAGE_LINK: ${{ secrets.EXTENDED_IMAGE_LINK }}
         PLOGON_SECRETS_PK: ${{ secrets.PLOGON_SECRETS_PK }}
         PLOGON_SECRETS_PK_PASSWORD: ${{ secrets.PLOGON_SECRETS_PK_PASSWORD }}
         XLWEB_KEY: ${{ secrets.XLWEB_KEY }}
+        PLOGON_S3_ACCESSKEY: ${{ secrets.PLOGON_S3_ACCESSKEY }}
+        PLOGON_S3_SECRET: ${{ secrets.PLOGON_S3_SECRET }}
+        PLOGON_S3_REGION: ${{ secrets.PLOGON_S3_REGION }}
       run: |
         dotnet run -- \
         --manifest-folder="${{ github.workspace }}/manifests" \
         --output-folder="${{ github.workspace }}/output" \
         --work-folder="${{ github.workspace }}/work" \
         --static-folder="${{ github.workspace }}/Plogon/Plogon/static" \
         --artifact-folder="${{ github.workspace }}/artifacts" \
+        --build-overrides-file="${{ github.workspace }}/manifests/overrides.toml" \
         --ci --mode=Commit --build-all
       
     - name: Upload artifact
@@ -77,7 +90,7 @@ jobs:
         git config --local user.email "[email protected]"
         git config --local user.name "GitHub Action"
         git add .
-        git commit -m "Update distribute"
+        git commit -m "Update distribute (${{ github.sha }})"
         
     - name: Push plugin dist
       uses: ad-m/github-push-action@master

README.md

@@ -1,15 +1,14 @@
 # DalamudPluginsD17
 
-Hi! This is the plugin repository for the [Dalamud plugin framework for Final Fantasy XIV](https://github.com/goatcorp/Dalamud). This repository is a successor to [DalamudPlugins](https://github.com/goatcorp/DalamudPlugins) and implements [DIP17](https://github.com/goatcorp/DIPs/blob/main/text/17-automated-build-and-submit-pipeline.md) to make the submission process easier and faster.
+Hi! This is the plugin repository for the [Dalamud plugin framework for Final Fantasy XIV](https://github.com/goatcorp/Dalamud). This repository implements [DIP17](https://github.com/goatcorp/DIPs/blob/main/text/17-automated-build-and-submit-pipeline.md) to make the submission process easier and faster.
 
 ## Publishing your plugin
 
 ### Preparing your repository
 
 - Ensure your plugin is on a publically accessible Git repo (GitHub, GitLab, any self-hosted Git instance that allows HTTP clones without authentication)
 - Update your `.csproj`
-  - Set `<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>` in a `PropertyGroup`
-  - Use `$(DalamudLibPath)` if you aren't already, see <https://github.com/goatcorp/SamplePlugin/blob/master/SamplePlugin/SamplePlugin.csproj#L29-L63>
+  - Use `$(DalamudLibPath)` if you aren't already (see [the sample plugin](https://github.com/goatcorp/SamplePlugin/blob/c6a5f5fcbf8e6812f274fab6347307c0283bd6fb/SamplePlugin/Dalamud.Plugin.Bootstrap.targets#L10) for reference)
 - Build your plugin in Release, commit your `.csproj` + the newly generated lock file
 
 ### Approval criteria
@@ -33,7 +32,7 @@ These criteria are intended to prevent issues for users. We're happy to work wit
 
 There are a few technical things that you must do before submitting your plugin here. They will make your plugin nicer to use.
 - Your plugin **must have** an `icon.png` that is no larger than 512x512 and no smaller than 64x64 in `images/`.
-- For regular ImGui windows that don't do anything special, like settings and utility windows, you should use the [Dalamud Windowing API](https://dalamud.dev/api/Dalamud.Interface.Windowing/). It enhances windows with a few nice features, like integration into the native UI closing-order.
+- For regular windows, like settings and utility windows, you should use the [Dalamud Windowing API](https://dalamud.dev/api/Dalamud.Interface.Windowing/). It enhances windows with a few nice features, like integration into the native UI closing-order, pinning, and opacity controls. If it looks like a window, it should use the windowing API. We won't reject updates to existing plugins for this, but we encourage everyone to upgrade.
 - Your plugin's version/assembly version **must not** be based on a timestamp or continually increasing build number. Every time your plugin is built with a specific commit, no matter the time or date, should produce the same version.
 
 ### Submitting
@@ -72,4 +71,4 @@ If your build process requires secrets, or you want to include a secret in your
 
 When submitting a plugin, please consider our [Acceptable Use Policy](<https://github.com/goatcorp/FFXIVQuickLauncher/wiki/Acceptable-Use-Policy-(Official-Plugin-Repository)>) & [Terms of Service](<https://github.com/goatcorp/FFXIVQuickLauncher/wiki/Terms-and-Conditions-of-Use-(XIVLauncher,-Dalamud-&-Official-Plugin-Repository)>), which, for example, detail the rights you need to grant us when uploading a plugin to this repository. 
 
-Please review the [plugin adoption policy](https://github.com/goatcorp/faq/blob/main/development.md#adoption) to understand what happens if you abandon your plugin. The FAQ also provides instructions on how to submit a plugin if taking over from another developer.
+Please review the [plugin adoption policy](https://dalamud.dev/faq/adoption) to understand what happens if you abandon your plugin. The FAQ also provides instructions on how to submit a plugin if taking over from another developer.

overrides.toml

@@ -1,3 +1,3 @@
 [channel_tracks]
-testing-live = "stg"
-stable = "stg"
+#testing-live = "apiX"
+#stable = "apiX"

stable/ARealmRecorded/manifest.toml

@@ -1,6 +1,7 @@
 [plugin]
 repository = "https://github.com/UnknownX7/ARealmRecorded.git"
-commit = "7de0beecd0fc5d2838cbbcbe6f77225bc1e131c4"
+commit = "1be2b1a9e210e0c7a153ad3ab441880c3be22633"
 owners = [ "UnknownX7" ]
 changelog = '''
-- Api9'''
+- Fixed for Dawntrail
+- Added waymark toggle persistence'''

stable/Accountant/manifest.toml

@@ -1,6 +1,6 @@
 [plugin]
 repository = "https://github.com/Ottermandias/Accountant.git"
-commit = "fc0ce604830dea4a28a8ce85c47262c056f519c6"
+commit = "239ace1939dded9a9ff10002b6931074c42e86c5"
 owners = [
     "Ottermandias",
 ]

stable/ActionTimeline/manifest.toml

@@ -1,6 +1,6 @@
 [plugin]
 repository = "https://github.com/Tischel/ActionTimeline.git"
-commit = "5280394852b052dd4a3d896aa12cf11c0d4ad02d"
+commit = "f877de33a550a331db48d97061da828affa5e6af"
 owners = ["Tischel"]
 project_path = "ActionTimeline"
-changelog = "- Added support for patch 6.5 and Dalamud API 9."
+changelog = "- Added support for Dawntrail and Dalamud API 10."

stable/AdaptiveHud/manifest.toml

@@ -1,8 +1,8 @@
 [plugin]
 repository = "https://github.com/Helios747/AdaptiveHudPlugin.git"
-commit = "2281bea1bcca392caa7b2cd7d359e3bc7de18ec2"
+commit = "0ea93f7c4b2acd69c1084752ba7d28fa73d96053"
 owners = [
     "Helios747"
 ]
 project_path = "AdaptiveHud"
-changelog = "Initial API9 work"
+changelog = "fix problem where config window can get stuck"

stable/AdventurerInNeed/manifest.toml

@@ -1,6 +1,6 @@
 [plugin]
 repository = "https://github.com/Caraxi/AdventurerInNeed.git"
-commit = "33ebdaca59f12604394304943d4191c9acf41aa8"
+commit = "7e4b5d87e3c2079c4d84f44b58d1024e402ac08d"
 owners = [
     "Caraxi",
 ]

stable/AudibleCharacterStatus/manifest.toml

@@ -1,9 +1,11 @@
 [plugin]
 repository = "https://github.com/Arrenton/AudibleCharacterStatus.git"
-commit = "d4615cb10e8c6960f29609b595f219e7374245c9"
+commit = "ec1f35d9981b22ebdd841bd226242da32708b14b"
 owners = [
     "Arrenton",
 ]
 changelog = """
-Updated for API 8, volume level setting provides a more consistant change.
+Updated for API 10.
+Added support for OGG files.
+Added an error message for when there's an issue with a file.
 """

stable/AutoMountBgm/manifest.toml

@@ -0,0 +1,6 @@
+[plugin]
+repository = "https://github.com/PrincessRTFM/AutoMountBGM.git"
+owners = [ "PrincessRTFM",]
+project_path = ""
+commit = "33f4c4b1fe41ae11c69f6d62b4671417217cdba8"
+changelog = "UI checkboxes work correctly now. Additionally, I've actually released the fix that was sitting on my hard drive for the last week."

stable/AutoTimer/manifest.toml

@@ -0,0 +1,9 @@
+[plugin]
+repository = "https://github.com/s5bug/AutoTimer.git"
+commit = "282ceb1a287e6fe31040380b4cc9fa20f06a199e"
+owners = ["s5bug"]
+project_path = "AutoTimer"
+changelog = '''
+- Updated to Dawntrail
+- Resolved issue where Inspiration was incorrectly counting towards Pictomancer auto-attack haste
+- Added option to scale the bar'''

stable/AvantGarde/manifest.toml

@@ -0,0 +1,12 @@
+[plugin]
+repository = "https://github.com/NeNeppie/AvantGarde.git"
+commit = "5c6fc00d1a4a3a6d37f8cdb5df74e07fb66ade5b"
+owners = ["NeNeppie"]
+project_path = "AvantGarde"
+changelog = """
+Moved to stable:
+- Fix incompatibility with multi-monitor support.
+Available for testing:
+- Added item interaction. Click on an item to open up a submenu.
+ - You can Try on, Search, Link and Copy to Clipboard, as well as open the item in your browser for extra info.
+"""

stable/BatteryGauge/manifest.toml

@@ -1,5 +1,5 @@
 [plugin]
 repository = "https://github.com/KazWolfe/XIVBatteryGauge.git"
-commit = "277361189206e49f1d20a1c196111bbec69550d0"
+commit = "a1b9eac798800eac55c31a1712284cd8e28a1724"
 owners = ["KazWolfe"]
 project_path = "BatteryGauge"

stable/BeegWindow/manifest.toml

@@ -0,0 +1,6 @@
+[plugin]
+repository = "https://github.com/arcanedisgea/beegwindow.git"
+commit = "3f19c4f8a1eb2d7a0d21466631414f868037cea7"
+owners = ["ArcaneDisgea"]
+project_path = "BeegWindow"
+changelog = "Initial Release"

stable/BetterInBlue/manifest.toml

@@ -1,5 +1,5 @@
 [plugin]
 repository = "https://github.com/NotNite/BetterInBlue.git"
-commit = "1bd0fbe9ed8289b4122e1395d3b3f60d984d01e5"
+commit = "75fdb85fbfb16a67713a600c02a0e6ef375bffd8"
 owners = ["NotNite"]
 project_path = "BetterInBlue"

stable/BetterMountRoulette/manifest.toml

@@ -1,6 +1,7 @@
 [plugin]
 repository = "https://github.com/CMDRNuffin/BetterMountRoulette.git"
-commit = "5e94dea7f41e09d4f3bcdf94369a685c36195989"
-version = "1.2.0.14"
+commit = "206de4de89d1da0a2fc22f01ad6bb37b4ef4491d"
+version = "1.5.0.20"
 owners = ["CMDRNuffin"]
-changelog = """Fix crash on load"""
+changelog = """- Actual fix for the crashing issue from last time by replacing very brittle readonly memory manipulation with much more stable hooks.
+- Fixed a second crash that would occur if the action menu was never opened before loading or unloading the plugin while logged in."""

stable/BetterPartyFinder/manifest.toml

@@ -1,5 +1,6 @@
 [plugin]
-repository = 'https://git.anna.lgbt/anna/BetterPartyFinder.git'
-commit = '6ee7d4a1028649e330f2a87fc555287843906b83'
-owners = [ 'lojewalo' ]
-changelog = 'API 9'
+repository = "https://github.com/Infiziert90/BetterPartyFinder.git"
+commit = "5287b000f3aa52cebddc083e3fe486db7bcd9378"
+owners = [
+  "Infiziert90"
+]

stable/BetterPlaytime/manifest.toml

@@ -1,6 +1,6 @@
 [plugin]
 repository = "https://github.com/Infiziert90/BetterPlaytime.git"
-commit = "c17264de1bd0ef429bac989439804be12ce4f06b"
+commit = "2645f5a4479b8d20670cbf26cf591fe7f02e4dca"
 owners = [
     "Infiziert90",
 ]

stable/BetterShadows/manifest.toml

@@ -1,10 +1,10 @@
 [plugin]
 repository = "https://github.com/Drahsid/BetterShadows.git"
-commit = "4bdc9f3e87b55afd6cbb4d3d45ceb80620251abc"
+commit = "835a7bc994d95f74c6b7a6bf3f06c8d27092973c"
 owners = ["Drahsid"]
 project_path = "BetterShadows"
 changelog = """
-- Updated for 6.5
-- Updated for API9
+- Made the appearance of shadows behave correctly when using "Strongest" shadow softening setting. Note that the "Strongest" shadow softening setting has vanilla bugs which may be more pronounced at higher shadowmap resolutions.
+- Added option to Dynamically adjust shadow cascade distances based on the original game values, and the resolution of the global shadowmap. This is toggled on by default, since most people were not using the per-territory cascade settings. This should naturally make shadows appear at greater distances, with higher quality.
 """
 

stable/BigPlayerDebuffs/manifest.toml

@@ -5,7 +5,7 @@
 # must be accessible (i.e. no `git` or `ssh` URLs, as the agent cannot clone those)
 repository = "https://github.com/rgd87/BigPlayerDebuffs.git"
 # The commit to check out and build from the repository.
-commit = "9493748c6ba13b1d494672700fac043c3bb593bc"
+commit = "6401d99e18f84535d70d5cac7aa7110b9f00e453"
 # The people authorised to update this manifest (e.g. who can deploy updates). These are GitHub usernames.
 owners = [
     "d87"
@@ -15,7 +15,7 @@ owners = [
 # If empty or unspecified, it will be assumed the project is in the root of the repository.
 # project_path = "plugin"
 # The changelog for this version. Will be shown in-game, as well on the Goat Place Discord.
-changelog = "v1.1.0.9 - 6.5 Dalamud Update"
+changelog = "v1.1.0.10 - API10 Dawntrail update"
 # Optional: the version of the plugin. If not present, the `<Version>` specified in the `csproj`
 # will be used. If this is specified, `<Version>` must not be specified - they are mutually
 # exclusive. This allows CI workflows to generate new manifests based on e.g. Git repo tags.

stable/BlueMageHelper/manifest.toml

@@ -1,6 +1,6 @@
 [plugin]
 repository = "https://github.com/Infiziert90/BlueMageHelper.git"
-commit = "5fa0efda6d73d8920181fb528447359f17835c85"
+commit = "b8939294bcc3760918824815475a8982b38930af"
 owners = [
     "Infiziert90",
 ]

stable/BozjaBuddy/manifest.toml

@@ -1,9 +1,9 @@
 [plugin]
 repository = "https://github.com/kaleidocli/BozjaBuddy.git"
-commit = "1fa775ae7ca43672e9c49da675a6467ddd31d8e1"
+commit = "3c15e4ab559f76bf67ea0346b49b9d38af641b35"
 owners = ["kaleidocli"]
 project_path = "BozjaBuddy"
 changelog = """
-Bozja Buddy 1.1.5.4
-API 9
+Bozja Buddy 1.1.6.1
+- Added plugin preview images.
 """

stable/Browsingway/manifest.toml

@@ -1,10 +1,9 @@
 [plugin]
 repository = "https://github.com/Styr1x/Browsingway.git"
-commit = "5c1a42181d3e98dbb03caaa12ce5e6d6082983dd"
+commit = "cfef0284a7bfb2847c542662861fb31bde048ba6"
 owners = ["Styr1x"]
 project_path = "Browsingway"
 changelog = """\
-- Chromium 117.0.5938.132 (fix for CVE-2023-4863 and CVE-2023-5217)
-- API9 compatibility
-- Custom CSS feature by xorus/olee (experimental, unsupported)
+- Fix local storage not working after Chromium update
+  Note: Due to encryption changes in Chromium, local storage data from previous versions will be lost.
 """

stable/BurntToast/manifest.toml

@@ -1,5 +1,6 @@
 [plugin]
-repository = 'https://git.anna.lgbt/anna/BurntToast.git'
-commit = 'd4faa3757b5c9cb9acdcd83d4330a485cfb50a5e'
-owners = [ 'lojewalo' ]
-changelog = 'API 9'
+repository = 'https://github.com/Xpahtalo/BurntToast.git'
+commit = 'ec82f40fca072da2ecb6a12c4f9e6994c7cd6d5c'
+owners = [ 'Xpahtalo' ]
+project_path = "BurntToast"
+changelog = """Fix BattleTalk bug."""

stable/CharacterPanelRefined/manifest.toml

@@ -1,8 +1,9 @@
 [plugin]
 repository = "https://github.com/Kouzukii/ffxiv-characterstatus-refined.git"
-commit = "cee423cf63e7b637c2fc0ceb8de320140dccab62"
+commit = "270fca12a588f18c6bc9f1c6a34480a7ec56090a"
 owners = ["Kouzukii"]
 project_path = "CharacterPanelRefined"
 changelog = """
-Update for patch 6.5
+- Tenacity is now split between provided damage increase and mitigation
+- Updated some 7.0 math
 """

stable/ChatAlerts/manifest.toml

@@ -1,6 +1,6 @@
 [plugin]
 repository = "https://github.com/Ottermandias/ChatAlerts.git"
-commit = "21d0b2817fc30bc14718c84d9c7740b0f0cc5611"
+commit = "bba3fd03eeb065b45623a07aa6656d804bc23f8a"
 owners = [
     "Ottermandias",
 ]

stable/ChatBubbles/manifest.toml

@@ -1,7 +1,8 @@
 [plugin]
 repository = "https://github.com/Haplo064/ChatBubbles.git"
-commit = "64883cac88828d7543ba381c0496547f344c1a4c"
+commit = "fe803677085f3a9733177b7c842874cacb5118b1"
 owners = ["Haplo064", "MKhayle"]
 project_path = "ChatBubbles"
-changelog = """### Updated for 6.5 & API9 compatibility
-Haplo064 did all the work there, thanks Haplo """
+changelog = """### 2.1.7.1
+- Confirmed fixing Atticus the Primogenitor (yeepeeeeee)
+- What is that smell?"""