Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StackSellPrice (stable) #2073

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Conversation

PrincessRTFM
Copy link
Contributor

@PrincessRTFM PrincessRTFM commented Jul 2, 2023

HQ item prices are now handled correctly (fixed rounding logic) and
materia prices should be calculated properly, since they're treated
by the game as being HQ even though they can't be HQ. I blame SE.

Also updated XivCommon to latest (7.0.2) as well.

@bleatbot
Copy link
Collaborator

bleatbot commented Jul 2, 2023

Outdated attempt

Builds failed, please check action output.
The average merge time for plugin updates is currently 14 hours.

😰StackSellPrice [stable] - df60746 - Build system error: Response status code does not indicate success: 404 (Not Found).

Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Jul 2, 2023
@philpax
Copy link
Contributor

philpax commented Jul 4, 2023

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Jul 4, 2023

Outdated attempt

Builds failed, please check action output.

😰StackSellPrice [stable] - df60746 - Build system error: Response status code does not indicate success: 404 (Not Found).

Show log - Review

@philpax
Copy link
Contributor

philpax commented Jul 5, 2023

Hi there! Sorry about taking some time to figure out what's going on here - it looks like our NuGet downloader can't resolve the dependency on Microsoft.NETCore.App.Host.win, likely because they've removed an implicit redirect to the x64 build.

Can you update your dependencies and see if that fixes it? Sorry about this!

@PrincessRTFM
Copy link
Contributor Author

I may have just found the problem. Apparently dotnet restore followed by dotnet build --no-restore -c Release includes the problematic line in the package lockfile, while doing just dotnet build -c Release doesn't. I updated XivCommon to latest and rebuilt in a single step and it should work now. Gimme a few for the PR update.

@bleatbot
Copy link
Collaborator

bleatbot commented Jul 5, 2023

Outdated attempt

Builds failed, please check action output.

😰StackSellPrice [stable] - 74e987a - Build system error: Docker API responded with status code=NotFound, response={"message":"No such image: mcr.microsoft.com/dotnet/sdk:7.0.100"}

Show log - Review

@PrincessRTFM
Copy link
Contributor Author

...well, it's a new error message, so that's progress at least.

@philpax
Copy link
Contributor

philpax commented Jul 29, 2023

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

All builds OK!

✔️StackSellPrice [stable] - 74e987a - v4.1.3 - Diff (16 lines, prev. 4.1.1)

Show log - Review

@bleatbot bleatbot added size-small Diff for this PR is small. and removed build failed This plugin failed to build. labels Jul 29, 2023
@philpax philpax enabled auto-merge (squash) July 29, 2023 19:59
Copy link
Contributor

@philpax philpax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao I cannot believe this was blocked on a transient failure, how embarassing

@philpax philpax merged commit 4170fc5 into goatcorp:main Jul 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small Diff for this PR is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants