Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Mount Collectioner 1.0.0.0 #2095

Merged
merged 4 commits into from
Jul 29, 2023
Merged

[Testing] Mount Collectioner 1.0.0.0 #2095

merged 4 commits into from
Jul 29, 2023

Conversation

Samuelkaa
Copy link
Contributor

I resurrected this and fixed all errors of the past 😎

@bleatbot
Copy link
Collaborator

bleatbot commented Jul 8, 2023

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@philpax philpax added the new plugin This is a new plugin. label Jul 8, 2023
@bleatbot
Copy link
Collaborator

bleatbot commented Jul 8, 2023

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

1 similar comment
@bleatbot
Copy link
Collaborator

bleatbot commented Jul 8, 2023

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@reiichi001
Copy link
Contributor

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Jul 8, 2023

Outdated attempt

⚠️ No builds attempted! This probably means that your owners property is misconfigured.

👽MountCollectioner [testing-live] - 591ee6e - Not your plugin

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Jul 8, 2023

Outdated attempt

All builds OK!

✔️MountCollectioner [testing-live] - 591ee6e - v1.0.0.0 - Diff (1223 lines)

Show log - Review

@bleatbot bleatbot added the size-large Diff for this PR is large. label Jul 8, 2023
@bleatbot
Copy link
Collaborator

bleatbot commented Jul 23, 2023

Outdated attempt

All builds OK!

✔️MountCollectioner [testing-live] - 591ee6e - v1.0.0.0 - Diff (1223 lines)

Show log - Review

@bleatbot
Copy link
Collaborator

All builds OK!

✔️MountCollectioner [testing-live] - 591ee6e - v1.0.0.0 - Diff (1223 lines)

Show log - Review

@philpax philpax enabled auto-merge (squash) July 29, 2023 19:38
@philpax philpax merged commit 728addf into goatcorp:main Jul 29, 2023
3 checks passed
@philpax
Copy link
Contributor

philpax commented Jul 29, 2023

Congratulations on your first plugin!

As a first-time contributor, if you're in the XIVLauncher & Dalamud Discord server and would like to get access to the private developer channels for plugin feedback and others, please let us know your Discord handle and we'll grant you the role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants