Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] rtyping 0.1.0.0 #2778

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[Testing] rtyping 0.1.0.0 #2778

merged 1 commit into from
Nov 3, 2023

Conversation

apetih
Copy link
Contributor

@apetih apetih commented Oct 26, 2023

Moved around a considerable amount of code.

Changed Websocket Server/Client to use Socket.IO since it helped make my implementation cleaner and allows for easier addition or modification of features.
Moved most of the actual logic outside of the draw function.
Modified Typing detection to actually detect typing instead of just the blinking chat cursor, and made the typing status expire after a while of non-active typing, to make it actually reflect typing status.
Lastly, added some IPC provider, unsure how used or useful it'll be, but it's there. If there's any issues or changes needed to make it work correctly or to work with specific cases, can let me know.

Since the server changed quite a bit, currently running a second server on a different port for this new version, hence the port change on the client, as to not disrupt the current version from working. Will turn off the older server instance if and when this update gets pushed, and will revert back to the original port at some later time.

If nothing breaks for a while, might finally push this to stable at some point in the future too.

@bleatbot bleatbot enabled auto-merge (squash) October 26, 2023 13:50
@bleatbot
Copy link
Collaborator

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 2 hours.

✔️rtyping [testing-live] - 41218f9 - v0.1.0.0 - Diff (887 lines, prev. 0.0.3.0)

Show log - Review

@bleatbot bleatbot added the size-mid Diff for this PR is mid-sized. label Oct 26, 2023
@bleatbot bleatbot merged commit 2977089 into goatcorp:main Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-mid Diff for this PR is mid-sized.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants