Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] update scout helper to v0.2.0.0 #2934

Closed
wants to merge 6 commits into from

Conversation

dit-zy
Copy link
Contributor

@dit-zy dit-zy commented Nov 25, 2023

this is a somewhat big update because i got tunnel vision and didn't try to release more incrementally >_< (i will do that going forward!)

  • there are some substantial UI additions, and a large amount of supporting code
  • added a new copy mode allowing copying of a whole template with variables
  • adding zw3lf as an owner, given that we are collaborating a lot between scout helper and coord importer

@bleatbot bleatbot enabled auto-merge (squash) November 25, 2023 16:59
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 25, 2023

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 16 hours.

😰ScoutHelper [testing-live] - be3449e - Build system error: unsupported URL protocol

Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Nov 25, 2023
@dit-zy
Copy link
Contributor Author

dit-zy commented Nov 25, 2023

;-; i don't know what that error means. could it be the https://example.com i have as an example in the code?

@NotNite
Copy link
Contributor

NotNite commented Nov 25, 2023

Sorry about that, Plogon errors aren't the best - I'd suspect it's from the Git submodule you have using Git over SSH. Try switching it to HTTPS.

auto-merge was automatically disabled November 25, 2023 17:11

Head branch was pushed to by a user without write access

@dit-zy
Copy link
Contributor Author

dit-zy commented Nov 25, 2023

ah how interesting! thank you, i fixed!

@dit-zy dit-zy changed the title [Testing] update scout helper to v0.2.0.0 [Testing] update scout helper to v0.2.0.1 Nov 25, 2023
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 25, 2023

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌ScoutHelper [testing-live] - 4231870 - Build failed (Diff)

Show log - Review

@NotNite
Copy link
Contributor

NotNite commented Nov 25, 2023

Uh, interesting! That might be a bug in submodule restoration on the build system. Likely not your fault.

@dit-zy
Copy link
Contributor Author

dit-zy commented Nov 25, 2023

_<

i did notice that ottergui has its own submodule for otterguiinternal that is using ssh instead of https. i wonder if that's relevant

@philpax
Copy link
Contributor

philpax commented Nov 25, 2023

Huh. That's pretty weird - it looks like the only point of difference that I can see is that Otter has branch = main in his .gitmodules (https://github.com/Ottermandias/GatherBuddy/blob/main/.gitmodules). Can you try that and see if it makes any difference? (I wouldn't expect it to, but...)

@dit-zy
Copy link
Contributor Author

dit-zy commented Nov 25, 2023

oh interesting. i'll try that next. otter pushed out a change to use https with his own submodule so we're seeing if that works

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 25, 2023

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌ScoutHelper [testing-live] - b16758a - Build failed (Diff)

Show log - Review

@Ottermandias
Copy link
Contributor

Huh. That's pretty weird - it looks like the only point of difference that I can see is that Otter has branch = main in his .gitmodules (https://github.com/Ottermandias/GatherBuddy/blob/main/.gitmodules). Can you try that and see if it makes any difference? (I wouldn't expect it to, but...)

GatherBuddy does not yet use a version of OtterGui that has submodules though.

@dit-zy
Copy link
Contributor Author

dit-zy commented Nov 26, 2023

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 26, 2023

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌ScoutHelper [testing-live] - b16758a - Build failed (Diff)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 26, 2023

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

😰ScoutHelper [testing-live] - c35de51 - Build system error: No valid git object identified by 'c35de5130c3eaba8bb4d7d6aefacfa3584dd2810' exists in the repository.

Show log - Review

@dit-zy
Copy link
Contributor Author

dit-zy commented Nov 26, 2023

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 26, 2023

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌ScoutHelper [testing-live] - c35de51 - Build failed (Diff)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 26, 2023

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️ScoutHelper [testing-live] - 8c975fd - v0.2.0.0 - Diff (773 lines, prev. 0.1.0.0)

Show log - Review

@bleatbot bleatbot added size-mid Diff for this PR is mid-sized. and removed build failed This plugin failed to build. labels Nov 26, 2023
@dit-zy dit-zy changed the title [Testing] update scout helper to v0.2.0.1 [Testing] update scout helper to v0.2.0.0 Nov 26, 2023
@bleatbot
Copy link
Collaborator

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️ScoutHelper [testing-live] - a70758e - v0.2.0.0 - Diff (759 lines, prev. 0.1.0.0)

Show log - Review

@dit-zy dit-zy closed this Nov 26, 2023
@dit-zy
Copy link
Contributor Author

dit-zy commented Nov 26, 2023

closing this PR because it's a mess of changes and i don't want any reviewers to be confused. will open a new one shortly with the final, working commit hash >_<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-mid Diff for this PR is mid-sized.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants