[Testing] Absolute Roleplay #3941

serifas · 2024-07-12T03:48:27Z

No description provided.

bleatbot · 2024-07-12T03:50:47Z

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently more than a day.

😰Absolute-Roleplay [testing-live] - db9cc5c - Build system error: DalamudPackager output not found, make sure it is installed

Show log - Review

bleatbot · 2024-07-12T04:09:29Z

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

😰Absolute-Roleplay [testing-live] - 783ae6d - Build system error: DalamudPackager output not found, make sure it is installed

Show log - Review

bleatbot · 2024-07-12T04:21:43Z

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

😰Absolute-Roleplay [testing-live] - 03ddee3 - Build system error: DalamudPackager output not found, make sure it is installed

Show log - Review

bleatbot · 2024-07-12T04:39:34Z

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

😰Absolute-Roleplay [testing-live] - 340584e - Build system error: DalamudPackager output not found, make sure it is installed

Show log - Review

bleatbot · 2024-07-12T04:46:52Z

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AbsoluteRoleplay [testing-live] - 340584e - v0.0.0.1 - Repo ^{^{(New plugin)}}

Show log - Review

Figured out there was a small chance of auto login not working and actually locking the connection for the user, This fixes it.

bleatbot · 2024-07-17T06:31:44Z

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AbsoluteRoleplay [testing-live] - ba55129 - v0.0.0.1 - Repo ^{^{(New plugin)}}

Show log - Review

reiichi001 · 2024-07-25T02:40:25Z

Testing results:

I would show a warning if the passwords do not match during registration. Currently, the plugin does not react. (the same applies to the forget password window)
If a user closes the verification window, there's no way to get it back. The plugin will just say the email is already in use.
A user can submit a forgot password before they have verified their account. (Is this intentional?)
After submitting information for account restoration, the window does not go away. It also has cut-off text.
The wifi button by connected does not appear to do anything. Can you elaborate on what this is for?
the DTRBar entry might not actually be by the map. I would suggest rewording this to "server info bar" or "top information bar" or similar.
While logged in, the connections button does not seem to do anything

serifas · 2024-07-26T03:18:55Z

I will update the source with the changes. Just give me until probably tomorrow to submit it. Thank you for updating me.

serifas · 2024-07-26T03:43:01Z

also the way I have the registration setup with verification is working as I want it to asside from the message not displaying if passwords don't match, and the sizing issue.
The restoration window is intended to allow the user to request multiple times so if they close it they can just submit another request.
The connection button is for if the server goes down the users can manually reconnect. It doesn't really do anything if the server connection hasn't died.
As far as the DTRBar goes, are you talking about the hint I gave in the command to open the window?
I am fixing the window sizing and password messages tho. but the rest I believe is working correctly.

Set messages for passwords not matching and scaled the restoration window correctly, as well as moved away from config values when sending data to server as it relied on the user checking remember me.

bleatbot · 2024-07-26T04:01:29Z

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AbsoluteRoleplay [testing-live] - 02c0683 - v0.0.0.1 - Repo ^{^{(New plugin)}}

Show log - Review

Fixed an issue where the registration key would some times not work after registering.

bleatbot · 2024-07-29T17:53:06Z

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AbsoluteRoleplay [testing-live] - add8e04 - v0.0.0.1 - Repo ^{^{(New plugin)}}

Show log - Review

serifas · 2024-09-01T02:15:05Z

is this still being reviewed?

reiichi001 · 2024-09-03T19:25:14Z

is this still being reviewed?

It's still making its way through review. The PAC member assigned to code review has not had a lot of availability due to IRL taking priority. (And other PAC members who can do the code review portion have also been pretty busy.) I'll mention this in our internal review sections.

serifas · 2024-09-05T21:54:42Z

thank you, sorry, I didn't mean to come off as pestering <3

Few minor bug fixes.

bleatbot · 2024-09-21T21:10:05Z

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AbsoluteRoleplay [testing-live] - add8e04 - v0.0.0.1 - Repo ^{^{(New plugin)}}

Show log - Review

bleatbot · 2024-09-21T21:10:50Z

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AbsoluteRoleplay [testing-live] - d02a5e0 - v0.0.0.1 - Repo ^{^{(New plugin)}}

Show log - Review

serifas added 2 commits July 11, 2024 20:40

Absolute Roleplay

81d13fa

Absolute Roleplay

3a612a7

bleatbot enabled auto-merge (squash) July 12, 2024 03:48

bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Jul 12, 2024

bleatbot assigned lmcintyre Jul 12, 2024

Trying to fix error

f146041

auto-merge was automatically disabled July 12, 2024 04:07
Head branch was pushed to by a user without write access

Updated InternalName

56b2c4a

Update manifest.toml

d82ed05

serifas added 2 commits July 11, 2024 21:44

Changing Folder name appropriately

e73fa5c

Merge branch 'main' of https://github.com/serifas/Absolute-Roleplay

dce87f6

bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Jul 12, 2024

reiichi001 added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Jul 12, 2024

Update manifest.toml

b5b9740

Figured out there was a small chance of auto login not working and actually locking the connection for the user, This fixes it.

Update manifest.toml

f012230

Set messages for passwords not matching and scaled the restoration window correctly, as well as moved away from config values when sending data to server as it relied on the user checking remember me.

Needed fix for registration

499da46

Fixed an issue where the registration key would some times not work after registering.

serifas added 2 commits September 21, 2024 14:08

Merge branch 'goatcorp:main' into main

c9e9cd2

Update manifest.toml

433a84a

Few minor bug fixes.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Testing] Absolute Roleplay #3941

[Testing] Absolute Roleplay #3941

serifas commented Jul 12, 2024

bleatbot commented Jul 12, 2024 •

edited

Loading

Show log - Review

bleatbot commented Jul 12, 2024 •

edited

Loading

Show log - Review

bleatbot commented Jul 12, 2024 •

edited

Loading

Show log - Review

bleatbot commented Jul 12, 2024 •

edited

Loading

Show log - Review

bleatbot commented Jul 12, 2024 •

edited

Loading

Show log - Review

bleatbot commented Jul 17, 2024 •

edited

Loading

Show log - Review

reiichi001 commented Jul 25, 2024

serifas commented Jul 26, 2024

serifas commented Jul 26, 2024

bleatbot commented Jul 26, 2024 •

edited

Loading

Show log - Review

bleatbot commented Jul 29, 2024 •

edited

Loading

Show log - Review

serifas commented Sep 1, 2024

reiichi001 commented Sep 3, 2024

serifas commented Sep 5, 2024

bleatbot commented Sep 21, 2024 •

edited

Loading

Show log - Review

bleatbot commented Sep 21, 2024

[Testing] Absolute Roleplay #3941

Are you sure you want to change the base?

[Testing] Absolute Roleplay #3941

Conversation

serifas commented Jul 12, 2024

bleatbot commented Jul 12, 2024 • edited Loading

Show log - Review

bleatbot commented Jul 12, 2024 • edited Loading

Show log - Review

bleatbot commented Jul 12, 2024 • edited Loading

Show log - Review

bleatbot commented Jul 12, 2024 • edited Loading

Show log - Review

bleatbot commented Jul 12, 2024 • edited Loading

Show log - Review

bleatbot commented Jul 17, 2024 • edited Loading

Show log - Review

reiichi001 commented Jul 25, 2024

serifas commented Jul 26, 2024

serifas commented Jul 26, 2024

bleatbot commented Jul 26, 2024 • edited Loading

Show log - Review

bleatbot commented Jul 29, 2024 • edited Loading

Show log - Review

serifas commented Sep 1, 2024

reiichi001 commented Sep 3, 2024

serifas commented Sep 5, 2024

bleatbot commented Sep 21, 2024 • edited Loading

Show log - Review

bleatbot commented Sep 21, 2024

Show log - Review

bleatbot commented Jul 12, 2024 •

edited

Loading

bleatbot commented Jul 12, 2024 •

edited

Loading

bleatbot commented Jul 12, 2024 •

edited

Loading

bleatbot commented Jul 12, 2024 •

edited

Loading

bleatbot commented Jul 12, 2024 •

edited

Loading

bleatbot commented Jul 17, 2024 •

edited

Loading

bleatbot commented Jul 26, 2024 •

edited

Loading

bleatbot commented Jul 29, 2024 •

edited

Loading

bleatbot commented Sep 21, 2024 •

edited

Loading