[Testing] QuestTracker v1.0.0.0

[isaiahcat]

No description provided.

[bleatbot]

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 6 hours.

✔️QuestTracker [testing-live] - 35733d9 - v1.0.0.0 - Repo ^{(New plugin)}

Show log - Review

[philpax]

This plugin is now in the plugin review queue; we hope to get back to you soon!

[philpax]

bleatbot, rebuild

[bleatbot]

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️QuestTracker [testing-live] - 35733d9 - v1.0.0.0 - Repo ^{(New plugin)}

Show log - Review

[Critical-Impact]

Test Results:
Plugin does finish loading however I get an error
Error loading QuestData from data.jason
Could not find file 'Z:\home\myname\.xlcore\data.json

When I try to open either of the windows I get

18:37:19.115 | ERR | Exception during raise of "Void DrawUI()"
	System.NullReferenceException: Object reference not set to an instance of an object.
	   at QuestTracker.QuestDataManager.UpdateQuestData(QuestData questData) in /work/repo/QuestTracker/QuestDataManager.cs:line 97
	   at QuestTracker.MainWindow.Draw() in /work/repo/QuestTracker/MainWindow.cs:line 52
	   at Dalamud.Utility.EventHandlerExtensions.HandleInvoke(Action act) in C:\goatsoft\companysecrets\dalamud\\Utility\EventHandlerExtensions.cs:line 124
18:37:20.121 | INF | [LOCALPLUGIN] Finished unloading "QuestTracker"

I'm running XIV on linux, this shouldn't generally make a difference but if you are loading a file of some description, you'll need to make sure your paths are cross platform compatible. If you need help just tag me.

[wolfcomp]

To what Critical posted, I have located the issue and also submitted a PR for fixing it as grabbing files from where the DLL is located is prone to issues PR in question: isaiahcat/QuestTracker#1

[philpax]

Hi @isaiahcat, please merge the above PR, or a similar fix, at your convenience - that's the only thing blocking the merge right now 🙂

[isaiahcat]

Merged and updated the manifest.toml to point to the latest commit. Thanks for the help, everyone!

[bleatbot]

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌QuestTracker [testing-live] - f7d56b7 - Build failed (Diff)

Show log - Review

[Haselnussbomber]

The assembly name was misspelled in the GetManifestResourceStream call (QeustTracker instead of QuestTracker):
isaiahcat/QuestTracker@f7d56b7#diff-8d20cea1ac66c19c4da60f6a04446e7814520326864e634c85dc035299b1217cR33

Also make sure to build for net8.0-windows here: https://github.com/isaiahcat/QuestTracker/blob/master/QuestTracker/QuestTracker.csproj#L10

[philpax]

Hi @isaiahcat, just checking in on this - it looks like you'll have to apply the fixes above and then you should hopefully be good to go 🙏

[isaiahcat]

All fixed :) Apologies, I didn't get notified about these comments for some reason

[bleatbot]

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌QuestTracker [testing-live] - 564ea8e - Build failed (Diff)

Show log - Review

[bleatbot]

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌QuestTracker [testing-live] - 564ea8e - Build failed (Diff)

Show log - Review

[wolfcomp]

@isaiahcat Forgot to do one thing during the pr, which was including using System.Reflection; which is currently causing the build to fail in QuestDataManager.cs

[bleatbot]

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️QuestTracker [testing-live] - 2ab4aff - v1.0.0.0 - Repo ^{(New plugin)}

Show log - Review

[philpax]

Congratulations on your first plugin!

As a first-time contributor, if you're in the XIVLauncher & Dalamud Discord server and would like to get access to the private developer channels for plugin feedback and others, please let us know your Discord handle and we'll grant you the role.

[isaiahcat]

Thank you!

I'm already in the discord server with my nickname set to isaiahcat :) I already have the "dev channels" role, unless you're talking about something else.