-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] DragoonMayCry v0.4.2 #4475
Conversation
Outdated attemptThis is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you. Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging. Please hold! |
bleatbot, approve |
Just read that I can't use NAudio.Wave due to it's dependencies. I'll try to remove it |
Head branch was pushed to by a user without write access
If the error you got was |
Looks like I was already using NAudio 2.2.1 when the build failed. I don't know why the dependency doesn't appear on their side, but it does on mine. I just tested locally. |
This plugin is now in the plugin review queue; we hope to get back to you soon! |
Test Results:
|
I'll look it up, and yeah nothing will show up if you just used one action, you have to use several GCDs |
I'll hold off on merging until those UI quirks are fixed, but I'm happy to do so afterwards 🙂 |
Errors should be fixed with this version. You may need to delete the plugin conf file if you want to retest installation. |
That's good enough for me - we can release this to the (testing) public now, they should be able to provide you with more feedback 🙂 |
Congratulations on your first plugin! As a first-time contributor, if you're in the |
My Discord ID is Felscream |
It's a plugin that tries to add flavour to the game combat by adding a style system inspired by the Devil May Cry series.