Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] DragoonMayCry v0.4.2 #4475

Merged
merged 8 commits into from
Sep 2, 2024
Merged

[Testing] DragoonMayCry v0.4.2 #4475

merged 8 commits into from
Sep 2, 2024

Conversation

Felscream
Copy link
Contributor

@Felscream Felscream commented Aug 26, 2024

It's a plugin that tries to add flavour to the game combat by adding a style system inspired by the Devil May Cry series.

  • There are 8 tiers : unranked, D, C, B, A, S, SS, SSS
  • You score by dealing damage
  • You go to the next tier if your score passes a certain threshold, a sound effect can be played if activated in the settings
  • You lose points overtime
  • The amount of points gained is reduced if you clip your GCD
  • You go back to the previous tier if your score is under a threshold for a set amount of time, or you stop rolling your GCD.
  • Casting a Limit Break charges your gauge.
  • Dying or cancelling a limit break cast sets you to D

@bleatbot
Copy link
Collaborator

bleatbot commented Aug 26, 2024

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@bleatbot bleatbot enabled auto-merge (squash) August 26, 2024 00:25
@philpax
Copy link
Contributor

philpax commented Aug 26, 2024

bleatbot, approve

@philpax philpax added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Aug 26, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Aug 26, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌DragoonMayCry [testing-live] - 4149a4a - Build failed (Diff)

Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Aug 26, 2024
@Felscream
Copy link
Contributor Author

Just read that I can't use NAudio.Wave due to it's dependencies. I'll try to remove it

auto-merge was automatically disabled August 26, 2024 08:42

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Aug 26, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️DragoonMayCry [testing-live] - e31f956 - v0.0.1.0 - Repo (New plugin)

Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Aug 26, 2024
@Aida-Enna
Copy link
Contributor

If the error you got was
error NETSDK1073: The FrameworkReference 'Microsoft.WindowsDesktop.App.WindowsForms' was not recognized, you can switch to a lower version of NAudio that works and doesn't use Winforms. It looks like it's 2.2.1, which is what Stanley Parable and a few other plugins use.

@Felscream
Copy link
Contributor Author

Looks like I was already using NAudio 2.2.1 when the build failed. I don't know why the dependency doesn't appear on their side, but it does on mine. I just tested locally.

@philpax philpax changed the title DragoonMayCry v0.0.1 [Testing] DragoonMayCry v0.0.1 Aug 27, 2024
@philpax
Copy link
Contributor

philpax commented Aug 27, 2024

This plugin is now in the plugin review queue; we hope to get back to you soon!

@bleatbot
Copy link
Collaborator

bleatbot commented Aug 27, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️DragoonMayCry [testing-live] - 55785c3 - v0.0.5.0 - Repo (New plugin)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Aug 28, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️DragoonMayCry [testing-live] - 5dfc642 - v0.1.0.0 - Repo (New plugin)

Show log - Review

@Felscream Felscream changed the title [Testing] DragoonMayCry v0.0.1 [Testing] DragoonMayCry v0.1.0 Aug 28, 2024
@philpax philpax added completed-rules-compliance This plugin is compliant with all rules. and removed pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. labels Aug 29, 2024
@Felscream Felscream changed the title [Testing] DragoonMayCry v0.1.0 [Testing] DragoonMayCry v0.4.2 Aug 30, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Aug 30, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️DragoonMayCry [testing-live] - 592ad61 - v0.4.2.0 - Repo (New plugin)

Show log - Review

@philpax philpax added completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. and removed pending-code-review This plugin still needs code review. labels Sep 1, 2024
@Critical-Impact
Copy link
Contributor

Test Results:
Plugin loads properly
A window pops up automatically that I can't remove until locking it in the config(a little unintuitive)
I set it to be active outside an instance and tried to attack a striking dummy and nothing showed up
I tried to unlock the score window and my log was spammed with these errors

18:41:42.290 | ERR | Exception during raise of "Void DrawUI()"
	System.Collections.Generic.KeyNotFoundException: The given key 'NoStyle' was not present in the dictionary.
	   at DragoonMayCry.UI.StyleRankUI.DrawMock(ImGuiWindowFlags windowFlags) in /work/repo/DragoonMayCry/UI/StyleRankUI.cs:line 158
	   at DragoonMayCry.UI.StyleRankUI.Draw() in /work/repo/DragoonMayCry/UI/StyleRankUI.cs:line 109
	   at DragoonMayCry.UI.PluginUI.DrawUI() in /work/repo/DragoonMayCry/UI/PluginUI.cs:line 63
	   at Dalamud.Utility.EventHandlerExtensions.HandleInvoke(Action act) in C:\goatsoft\companysecrets\dalamud\\Utility\EventHandlerExtensions.cs:line 124

@Felscream
Copy link
Contributor Author

Felscream commented Sep 2, 2024

I'll look it up, and yeah nothing will show up if you just used one action, you have to use several GCDs

@philpax
Copy link
Contributor

philpax commented Sep 2, 2024

I'll hold off on merging until those UI quirks are fixed, but I'm happy to do so afterwards 🙂

UI won't pop directly after installation.
Fixed error when in combat and unlocking window without any points
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 2, 2024

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️DragoonMayCry [testing-live] - ab3d8b1 - v0.5.1.0 - Repo (New plugin)

Show log - Review

@Felscream
Copy link
Contributor Author

Errors should be fixed with this version. You may need to delete the plugin conf file if you want to retest installation.

@philpax philpax added the completed-testing This plugin has been tested. label Sep 2, 2024
@philpax
Copy link
Contributor

philpax commented Sep 2, 2024

That's good enough for me - we can release this to the (testing) public now, they should be able to provide you with more feedback 🙂

@philpax philpax enabled auto-merge (squash) September 2, 2024 09:22
@philpax philpax merged commit 49cb4b4 into goatcorp:main Sep 2, 2024
2 checks passed
@philpax
Copy link
Contributor

philpax commented Sep 2, 2024

Congratulations on your first plugin!

As a first-time contributor, if you're in the XIVLauncher & Dalamud Discord server and would like to get access to the private developer channels for plugin feedback and others, please let us know your Discord handle and we'll grant you the role.

@Felscream
Copy link
Contributor Author

My Discord ID is Felscream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-rules-compliance This plugin is compliant with all rules. completed-testing This plugin has been tested. new plugin This is a new plugin. pending-testing This plugin still needs to be tested. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants