Chatter v1.2.1.0 #4495
Merged
Chatter v1.2.1.0 #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added plural handling for messages. Moved more messages to the message catalog including some that require pluralization. * Various cleanups and conversion to ImRaii. Before I knew that ImRaii existed, I created a similar library, so converting wasn't very difficult. Using theirs because it's supported and handles more cases than mine and why have duplicate code?
Added plural handling for messages.
|
Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it! The average merge time for plugin updates is currently 11 hours. ✔️Chatter [stable] - 294cdcd - v1.2.1.0 - Diff (1105 lines, prev. 1.2.0.0) - Semantic Show log - Review |
philpax
approved these changes
Aug 29, 2024
|
Please ensure the name of your plugin is in your PR title 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added plural handling for messages.
Moved more messages to the message catalog including some that require pluralization.
Before I knew that ImRaii existed, I created a similar library, so converting wasn't very difficult. Using theirs because it's supported and handles more cases than mine and why have duplicate code?