Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VenueManager v2.2.0 #4559

Merged
merged 1 commit into from
Oct 14, 2024
Merged

VenueManager v2.2.0 #4559

merged 1 commit into from
Oct 14, 2024

Conversation

Jrogo7
Copy link
Contributor

@Jrogo7 Jrogo7 commented Sep 9, 2024

No description provided.

@bleatbot bleatbot enabled auto-merge (squash) September 9, 2024 22:42
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 9, 2024

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@reiichi001
Copy link
Contributor

bleatbot, approve

@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Sep 10, 2024
@bleatbot
Copy link
Collaborator

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️VenueManager [testing-live] - 410c16f - v2.2.0 - Repo (New plugin)

Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. size-large Diff for this PR is large. labels Sep 10, 2024
@reiichi001 reiichi001 added completed-rules-compliance This plugin is compliant with all rules. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-testing This plugin has been tested. and removed pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. completed-rules-compliance This plugin is compliant with all rules. pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. labels Oct 7, 2024
@reiichi001
Copy link
Contributor

Congratulations on your first plugin added to the main Dalamud plugin repository!

As a first-time contributor, if you're in the XIVLauncher & Dalamud Discord server and would like to get access to the private developer channels for plugin feedback and others, please let us know your Discord handle and we'll grant you the role.

@bleatbot bleatbot merged commit e76e67c into goatcorp:main Oct 14, 2024
2 checks passed
@Jrogo7
Copy link
Contributor Author

Jrogo7 commented Oct 14, 2024

Hey! Thanks for the update. I think I'm in the right channels, but just incase my handle is jrogo.

@Jrogo7
Copy link
Contributor Author

Jrogo7 commented Oct 14, 2024

As a quick question if its ok to ask here. Is there a specific process from moving from the testing state to non testing?

@reiichi001
Copy link
Contributor

reiichi001 commented Oct 15, 2024

For the most part, there is no formal "when should you promote from testing" guidelines.

We have officially merged in some updated networking guidelines for plugins, but I haven't seen it get regenerated for the official dalamud.dev site just yet. You can find the pertinent bits here: https://github.com/goatcorp/dalamud-docs/pull/27/files.

Aside from that, I generally advise like a week or two and then promote it up. If you have any major changes like a large refactor, significant feature add/remove/change/etc coming in, it's preferred to send that over to testing first.

@Jrogo7 Jrogo7 deleted the feature/venuemanager branch October 15, 2024 02:52
@Jrogo7
Copy link
Contributor Author

Jrogo7 commented Oct 15, 2024

Sounds good. Thanks for the heads up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-rules-compliance This plugin is compliant with all rules. completed-testing This plugin has been tested. new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants