-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VenueManager v2.2.0 #4559
VenueManager v2.2.0 #4559
Conversation
Outdated attemptThis is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you. Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging. Please hold! |
bleatbot, approve |
Congratulations on your first plugin added to the main Dalamud plugin repository! As a first-time contributor, if you're in the |
Hey! Thanks for the update. I think I'm in the right channels, but just incase my handle is |
As a quick question if its ok to ask here. Is there a specific process from moving from the testing state to non testing? |
For the most part, there is no formal "when should you promote from testing" guidelines. We have officially merged in some updated networking guidelines for plugins, but I haven't seen it get regenerated for the official dalamud.dev site just yet. You can find the pertinent bits here: https://github.com/goatcorp/dalamud-docs/pull/27/files. Aside from that, I generally advise like a week or two and then promote it up. If you have any major changes like a large refactor, significant feature add/remove/change/etc coming in, it's preferred to send that over to testing first. |
Sounds good. Thanks for the heads up :) |
No description provided.