-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] DragoonMayCry v0.12.0.2 #4573
Conversation
Felscream
commented
Sep 14, 2024
•
edited
Loading
edited
- Sound files are now downloaded separately from https://github.com/Felscream/DragoonMayCry/releases/tag/v0.12.0.0 instead of being bundled directly with the plugin.
- Files are extracted into the DragoonMayCry's pluginConfigs directory.
- Each time the plugin is loaded, it will do a file integrity check on the additional assets.
- If the integrity check fails, the user is notified, existing assets are deleted and new ones are downloaded from the link above.
- Added more sound effects and dynamic background music selectable on a job-per-job basis.
- Dynamic background music is opt-in, and only playable inside non PvP instances.
- If the user configured a job to use dynamic background music, it will mute the game's BGM when they enter an instance with that job.
- The game BGM state is restored when they leave the instance, or choose a job inside the instance which doesn't have dynamic music enabled.
- Dynamic BGM files are cached in memory when the user enters an instance. They are cleared only when the plugin is disabled.
- Lots of duplicated code in the FSM namespace
Outdated attemptTake care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it! The average merge time for plugin updates is currently 15 hours. ✔️DragoonMayCry [testing-live] - 02b6055 - v0.12.0.0 - Diff (4760 lines, prev. 0.7.5.0) - Semantic Show log - Review |
Done some initial testing. New features look good and I'm not getting any major bugs or issues, nor any errors/warnings in xllog.
|
For Morrison and Nico, that's intended. The original game doesn't provide lines for D and C, and defaults to the original announcer (I checked on youtube). |
Head branch was pushed to by a user without write access