Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] DragoonMayCry v0.12.0.2 #4573

Merged
merged 4 commits into from
Sep 15, 2024
Merged

[Testing] DragoonMayCry v0.12.0.2 #4573

merged 4 commits into from
Sep 15, 2024

Conversation

Felscream
Copy link
Contributor

@Felscream Felscream commented Sep 14, 2024

  • Sound files are now downloaded separately from https://github.com/Felscream/DragoonMayCry/releases/tag/v0.12.0.0 instead of being bundled directly with the plugin.
  • Files are extracted into the DragoonMayCry's pluginConfigs directory.
  • Each time the plugin is loaded, it will do a file integrity check on the additional assets.
  • If the integrity check fails, the user is notified, existing assets are deleted and new ones are downloaded from the link above.
  • Added more sound effects and dynamic background music selectable on a job-per-job basis.
  • Dynamic background music is opt-in, and only playable inside non PvP instances.
  • If the user configured a job to use dynamic background music, it will mute the game's BGM when they enter an instance with that job.
  • The game BGM state is restored when they leave the instance, or choose a job inside the instance which doesn't have dynamic music enabled.
  • Dynamic BGM files are cached in memory when the user enters an instance. They are cleared only when the plugin is disabled.
  • Lots of duplicated code in the FSM namespace

@bleatbot bleatbot enabled auto-merge (squash) September 14, 2024 10:21
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 14, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 15 hours.

✔️DragoonMayCry [testing-live] - 02b6055 - v0.12.0.0 - Diff (4760 lines, prev. 0.7.5.0) - Semantic

Show log - Review

@bleatbot bleatbot added the size-large Diff for this PR is large. label Sep 14, 2024
@gnargle
Copy link
Contributor

gnargle commented Sep 14, 2024

Done some initial testing. New features look good and I'm not getting any major bugs or issues, nor any errors/warnings in xllog.
I did notice some functionality bugs with the new voices available:

  • Nico nor Morrison's voice do not function for D and C ranks, instead defaulting to the DMCV voice. IDK if this is because they doesn't have lines for D and C but from hitting the sample button a few times, it sounded like they do.
  • The only way I could hear the bgm without cranking the volume to max was to turn "apply game volume..." off. IMO remove the option entirely and have the volume be settable from the plugin only, else it adds too many variables.

@Felscream
Copy link
Contributor Author

For Morrison and Nico, that's intended. The original game doesn't provide lines for D and C, and defaults to the original announcer (I checked on youtube).
As for the BGM volume, maybe I'll default it to off later but I personally don't like loud BGM, that's why it's there at least to try and keep it in line with the rest of the game's volume on my personnal setup

auto-merge was automatically disabled September 14, 2024 18:07

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 14, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️DragoonMayCry [testing-live] - 1bfd94d - v0.12.0.0 - Diff (4760 lines, prev. 0.7.5.0) - Semantic

Show log - Review

@Felscream Felscream changed the title [Testing] DragoonMayCry v0.12.0.0 [Testing] DragoonMayCry v0.12.0.1 Sep 14, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 14, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️DragoonMayCry [testing-live] - ed593a4 - v0.12.0.1 - Diff (4761 lines, prev. 0.7.5.0) - Semantic

Show log - Review

@Felscream Felscream changed the title [Testing] DragoonMayCry v0.12.0.1 [Testing] DragoonMayCry v0.12.0.2 Sep 14, 2024
@bleatbot
Copy link
Collaborator

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️DragoonMayCry [testing-live] - af98698 - v0.12.0.2 - Diff (4760 lines, prev. 0.7.5.0) - Semantic

Show log - Review

@philpax philpax enabled auto-merge (squash) September 15, 2024 16:08
@philpax philpax merged commit 8326a1b into goatcorp:main Sep 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants