[Testing] Scout Helper v1.7.0 #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it! The average merge time for plugin updates is currently 9 hours. ✔️ScoutHelper [testing-live] - c2bba25 - v1.7.0.0 - Diff (90 lines, prev. 1.6.3.0) - Semantic Show log - Review |
reiichi001
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change doesn't introduce any new functionality. rather, it migrates a lot of functionality to a helper lib (
XIVHuntUtils) that now provides the same capabilities.XIVHuntUtils(xhu) was created because several features of scout helper are interesting to some other plugins. rather than recreating those features in the other plugins, i created xhu to house those features, and basically copied those things right out of scout helper.this change also introduces the use of the
DitzyExtensionslibrary. that is another library in the vain of xhu -- a bunch of common c# extensions and utils that i ended up creating in scout helper but found to be useful in other c# projects of mine so made a lib.