Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Camera 1.4.0 (Testing) #4584

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

Drahsid
Copy link
Contributor

@Drahsid Drahsid commented Sep 17, 2024

Update to hybrid camera I was working on around the end of Endwalker.
This adds controller support, and simplifies a lot of the implementation, allowing me to remove configuration options.
This might be illegal, since it directly hooks the movement code to adjust the behavior and switch from standard/legacy movement. I am putting this version in testing for now just in case there are some side effects I did not catch, though I did personally test to ensure various things still work (knockbacks, grabs, sliding floors, being frozen/unable to move, etc.)

@bleatbot bleatbot enabled auto-merge (squash) September 17, 2024 05:37
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 17, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 9 hours.

✔️HybridCamera [testing-live] - 42d5641 - v1.4.0.0 - Diff (111 lines) - Semantic

Show log - Review

@bleatbot bleatbot added move channel This plugin is being moved to another channel. size-small Diff for this PR is small. labels Sep 17, 2024
auto-merge was automatically disabled September 17, 2024 08:12

Head branch was pushed to by a user without write access

@Drahsid
Copy link
Contributor Author

Drahsid commented Sep 17, 2024

I ended up doing some more work on this. One more option has been added to make standard-style backpedaling move at full speed. This mechanically has no difference in comparison to legacy-style backpedaling (besides lower acceleration,) but might look strange to other players.

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 17, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️HybridCamera [testing-live] - c211e25 - v1.4.0.0 - Diff (173 lines) - Semantic

Show log - Review

@philpax
Copy link
Contributor

philpax commented Sep 25, 2024

Hi, apologies for the delay on this; we've been deliberating over the potentially illegal behaviour. We hope to have movement on this soon.

@Drahsid
Copy link
Contributor Author

Drahsid commented Sep 26, 2024

No worries, I thought as much.
I think if anything here is specifically illegal, it is the full-speed standard style backpedaling. Even though it has the same max speed and lower acceleration than legacy, it is pretty obvious when a player is using it, even the movement latency doesn't mask it.

@philpax philpax added the blocked Blocked on an issue that needs to be resolved before merge label Sep 26, 2024
@Drahsid
Copy link
Contributor Author

Drahsid commented Oct 14, 2024

I see this was marked as blocked, but I never received and correspondence as to the result of your deliberation.
What needs to be changed here?

@slotthhy
Copy link
Contributor

Hi! We've taken an extra close look at this and have deemed the "Fullspeed backpedal" too obvious to allow. To other players, it looks like a speedhack (and essentially is, considering the movement you're doing, backing up without turning, is not intended to be performed at that speed). The other smart strafe features are fine.

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ HybridCamera [testing-live] 03cdfac v1.4.0.0 - Diff (174 lines) - Semantic
2 Needs (⚠️ 1 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/Drahsid/DrahsidLib.git 8d9dd9ab866a485a177440ee91779d25d36fd587 ⚠️ NEW
1 hidden need (known safe NuGet packages).
Show log - Review

@Drahsid
Copy link
Contributor Author

Drahsid commented Oct 14, 2024

I've gone ahead and removed the fullspeed backpedal option.

@reiichi001 reiichi001 removed the blocked Blocked on an issue that needs to be resolved before merge label Oct 17, 2024
@reiichi001 reiichi001 merged commit 923fe27 into goatcorp:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
move channel This plugin is being moved to another channel. size-small Diff for this PR is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants