Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoBGM v1.0.0.0 #4616

Merged
merged 6 commits into from
Oct 11, 2024
Merged

AutoBGM v1.0.0.0 #4616

merged 6 commits into from
Oct 11, 2024

Conversation

meoiswa
Copy link
Contributor

@meoiswa meoiswa commented Sep 25, 2024

No description provided.

@bleatbot bleatbot enabled auto-merge (squash) September 25, 2024 17:20
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 25, 2024 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently more than a day.

😰autobgm [stable] - 7731e8f - Build system error: DalamudPackager output not found, make sure it is installed

Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Sep 25, 2024
@KazWolfe
Copy link
Member

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 25, 2024 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

😰autobgm [stable] - 7731e8f - Build system error: DalamudPackager output not found, make sure it is installed

Show log - Review

auto-merge was automatically disabled September 25, 2024 18:19

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 25, 2024 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AutoBGM [testing-live] - 7731e8f - v1.0.0.0 - Repo (New plugin)

Show log - Review

@bleatbot bleatbot added size-mid Diff for this PR is mid-sized. and removed build failed This plugin failed to build. labels Sep 25, 2024
@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Sep 25, 2024
@reiichi001
Copy link
Contributor

Readme file refers to another plugin. meoiswa/autobgm@7731e8f#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

@reiichi001 reiichi001 added completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. and removed pending-code-review This plugin still needs code review. labels Sep 25, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 26, 2024 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AutoBGM [testing-live] - d965b95 - v1.0.0.0 - Repo (New plugin)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 26, 2024 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AutoBGM [testing-live] - 4200303 - v1.0.0.0 - Repo (New plugin)

Show log - Review

@meoiswa
fix: minor indentation problem
445bddc 
fix: register main ui
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 28, 2024 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AutoBGM [testing-live] - f29d591 - v1.0.0.0 - Repo (New plugin)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 28, 2024 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️AutoBGM [testing-live] - df92c1e - v1.0.0.0 - Repo (New plugin)

Show log - Review

@goaaats
Copy link
Member

goaaats commented Oct 5, 2024

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Oct 5, 2024

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ AutoBGM [testing-live] df92c1e v1.0.0.0 - Repo (New plugin)
1 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001 reiichi001 removed the pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. label Oct 7, 2024
@reiichi001 reiichi001 added completed-rules-compliance This plugin is compliant with all rules. completed-testing This plugin has been tested. and removed pending-testing This plugin still needs to be tested. labels Oct 7, 2024
@reiichi001 reiichi001 merged commit 5b141d4 into goatcorp:main Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiichi001 reiichi001 reiichi001 approved these changes

Assignees

@ackwell ackwell

Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-rules-compliance This plugin is compliant with all rules. completed-testing This plugin has been tested. new plugin This is a new plugin. size-mid Diff for this PR is mid-sized.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@meoiswa @bleatbot @KazWolfe @reiichi001 @goaaats @ackwell