Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMMI Webhook Plugin v1.0.0.0 #4617

Merged
merged 6 commits into from
Oct 11, 2024
Merged

SAMMI Webhook Plugin v1.0.0.0 #4617

merged 6 commits into from
Oct 11, 2024

Conversation

HatTheTurtle
Copy link
Contributor

Plugin to send game information to the stream automation program SAMMI, allowing users to automate stream effects based on in-game events (e.g., apply an effect to their webcam on gaining a vuln stack, playing a sound byte/animation when they crit in buffs, etc.)

Feedback appreciated!

@bleatbot bleatbot enabled auto-merge (squash) September 25, 2024 20:53
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 25, 2024

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@reiichi001
Copy link
Contributor

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 25, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

😰SAMMIWebhookPlugin [testing-live] - 9b18152 - Build system error: DalamudPackager output not found, make sure it is installed

Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Sep 25, 2024
@NotNite
Copy link
Contributor

NotNite commented Sep 25, 2024

The folder name (SAMMIWebhookPlugin) must match the plugin internal name (SammiPlugin).

auto-merge was automatically disabled September 25, 2024 23:08

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 25, 2024

Outdated attempt

⚠️ No builds attempted! This probably means that your owners property is misconfigured.

Name Commit Status
Show log - Review

@bleatbot bleatbot removed new plugin This is a new plugin. build failed This plugin failed to build. labels Sep 25, 2024
@bleatbot
Copy link
Collaborator

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️SammiPlugin [testing-live] - 9b18152 - v0.0.0.1 - Repo (New plugin)

Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. size-large Diff for this PR is large. labels Sep 25, 2024
@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. completed-rules-compliance This plugin is compliant with all rules. completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-testing This plugin has been tested. and removed pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. labels Oct 7, 2024
@reiichi001
Copy link
Contributor

Congratulations on your first plugin added to the main Dalamud plugin repository!

As a first-time contributor, if you're in the XIVLauncher & Dalamud Discord server and would like to get access to the private developer channels for plugin feedback and others, please let us know your Discord handle and we'll grant you the role.

@reiichi001 reiichi001 merged commit 08a9f4d into goatcorp:main Oct 11, 2024
2 checks passed
@HatTheTurtle
Copy link
Contributor Author

That would be great, my discord handle is hattu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-rules-compliance This plugin is compliant with all rules. completed-testing This plugin has been tested. new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants