-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility rework 2 #1366
Open
rankynbass
wants to merge
17
commits into
goatcorp:master
Choose a base branch
from
rankynbass:compatibility-rework-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Compatibility rework 2 #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed ToolDownloader to UnixHelpers * Moved DxvkHud and MangoHud checkers to UnixHelpers * Removed unneeded "using" statements * Added flatpak and extraEnvironmentVars for future use
This was referenced Jul 26, 2023
Closed
marzent
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the 2nd version of the Compatibility rework, I left only a few minor comments here and there.
src/XIVLauncher.Common.Unix/Compatibility/CompatibilityTools.cs
Outdated
Show resolved
Hide resolved
src/XIVLauncher.Common.Unix/Compatibility/CompatibilityTools.cs
Outdated
Show resolved
Hide resolved
src/XIVLauncher.Common.Unix/Compatibility/CompatibilityTools.cs
Outdated
Show resolved
Hide resolved
* Moved download funcs to CompatibilityTools * Moved hud funcs to DxvkSettings * Simplified MergeLDPreload * Cleaned up formatting, deleted a commented-out function
marzent
approved these changes
Aug 2, 2023
rankynbass
force-pushed
the
compatibility-rework-2
branch
from
November 17, 2023 05:31
7413677
to
dd1d2a3
Compare
This should allow auto-merging with master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a new version of the compatibility rework. This version moves most of the logic back to XL.Common.Unix.
Wine download info, Dxvk download info, and various hud settings are passed to CompatibiltyTool, WineSettings, or DxvkSettings (instead of being pre-assembled as dictionary objects as in the previous PR). The necessary environment variables are created inside CompatibilityTool or DxvkSettings.
Here's the XL.Core PR: goatcorp/XIVLauncher.Core#64
Replaces #1348