Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade XIVLauncher.Core to net8 #141

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Upgrade XIVLauncher.Core to net8 #141

merged 5 commits into from
Jun 28, 2024

Conversation

Blooym
Copy link
Contributor

@Blooym Blooym commented Mar 26, 2024

No description provided.

@Blooym Blooym marked this pull request as draft March 26, 2024 14:22
@Maia-Everett
Copy link

Yes, please! .NET 6 has been removed from Ubuntu 24.04 LTS, which is releasing this week. I've already had to patch the csproj for building against .NET 8 for the PPA.

@KazWolfe
Copy link
Member

Would this affect users on Ubuntu 20.04? While 22.04 and newer seem to have .NET 8 in their repos, 20.04 is still supported for another year and does not (although MS' documentation states that you'd need to add their apt repo anyways, so possibly a moot point).

@Maia-Everett
Copy link

Yes, Ubuntu 22.04 and later all have .NET 8 in the official repository, and earlier Ubuntu versions, including 20.04, don't have any version of .NET in the official repository and will have to add the Microsoft repository, which includes .NET 8.

https://learn.microsoft.com/en-us/dotnet/core/install/linux-ubuntu-install?pivots=os-linux-ubuntu-2004&tabs=dotnet8

@rankynbass
Copy link
Contributor

rankynbass commented Jun 28, 2024

This works just fine, and seems to be necessary to get XIVLauncher.Core to build inside a flatpak. However, XL.Common also needs to be updated to net8 for the flatpak build, and I'm not sure how that affects things on the Windows side.

@Blooym Blooym marked this pull request as ready for review June 28, 2024 07:11
@Blooym Blooym requested a review from a team June 28, 2024 08:24
marzent
marzent previously approved these changes Jun 28, 2024
@Blooym Blooym requested a review from marzent June 28, 2024 08:46
@Blooym Blooym merged commit 833fb9b into main Jun 28, 2024
2 checks passed
@Blooym Blooym deleted the net8 branch June 28, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants