feat: add DXVK settings tab #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed a few settings from wine tab * Added dxvk settings to launcher.ini * Updated CreateCompatToolsInstance to work with new dxvkSettings * Requires PR#1205 from FFXIVQuickLauncher * Suggest doing PR#13, #15 on xlcore, for better look and feel.
rankynbass
force-pushed
the
add-dxvk-settings-tab
branch
from
2edc36d
to
21de7ae
Compare
rankynbass
force-pushed
the
add-dxvk-settings-tab
branch
from
783f4a9
to
ace2834
Compare
|
Updated to work with latest Dxvk rework changes in the submodule. See PR #1205. I don't know why the updates are showing as commited 5 months ago when I just posted them yesterday. |
marzent
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
LGTM, just needs to happen after goatcorp/FFXIVQuickLauncher#1205
Closed
|
Made obsolete by #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the XL.Core side of the DXVK settings patch. This requires PR #1205 from FFXIVQuickLauncher to work, otherwise it will not compile.
I also suggest adding PR #13, and PR #15, since those improve the UI to expose more information and make it more consistant.Edit: These PRs have been added already.