Add XL_APPID as an override for using Free Trial #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reiichi001
previously approved these changes
Jul 27, 2024
marzent
requested changes
Jul 27, 2024
| public static int GetAltAppId(string? appid) | ||
| { | ||
| int result; | ||
| if (int.TryParse(appid, out result)) |
There was a problem hiding this comment.
You can use if (int.TryParse(appid, out var result)) to make the code a bit more concise
There was a problem hiding this comment.
Alright, did this (with uint.TryParse() instead).
| @@ -16,6 +16,7 @@ public static class CoreEnvironmentSettings | |||
| public static bool ClearAll => CheckEnvBool("XL_CLEAR_ALL"); | |||
| public static bool? UseSteam => CheckEnvBoolOrNull("XL_USE_STEAM"); // Fix for Steam Deck users who lock themselves out | |||
| public static bool IsSteamCompatTool => CheckEnvBool("XL_SCT"); | |||
| public static int AltAppID => GetAltAppId(System.Environment.GetEnvironmentVariable("XL_APPID")); | |||
There was a problem hiding this comment.
Usually nullability is used here to indicate an env var not existing, instead of using a special value (like -1).
|
Alright, simplified the logic to use uint.TryParse(). If the conversion fails or the value is zero, AltAppId will be set to 0. I could use a nullable here, but the simple fact is that using an AppId of 0 is invalid anyway, so it's just as easy to make sure AltAppId is > 0 instead of checking for 0 and null. |
marzent
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes to the Free Trial / Demo, some users are having problems getting or keeping FFXIV Free Trial in their library. This allows the user to override the first AppID tried with some other number.
AppID will still fall back to the free trial if an invalid number is used, and if the value passed is not a number (or a number <= 0) it will be ignored.
Fun fact, using proton ids such as
XL_APPID=2805730for proton 9.0 does work. Not sure that would be the best idea, however.