Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve steam initialization and game launch feedback #187

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Improve steam initialization and game launch feedback #187

merged 1 commit into from
Oct 25, 2024

Conversation

rankynbass
Copy link
Contributor

  • Don't hide the window/show deck prompt until ffxiv actually starts launching. This prevents several seconds of the launcher disappearing and nothing happening.
  • Don't show the deck prompt in XLM mode (no manual swap is needed).
  • Improve steam initialization by using SteamAppId, which is provided by whatever entry you use XLM on in the Steam Library. This allows for use on non-ffxiv entries for Steam regions without FFXIV.

@rankynbass
Improve launcher and game launch logic
b2d4a5b 
* Don't hide the window/show deck prompt until ffxiv actually starts launching
  This saves several seconds of launcher disappearing and nothing happening
* Don't show the deck prompt in XLM mode (no manual swap is needed)
* Improve steam initialization: use SteamAppId, which is provided by whatever entry you use XLM on
  This allows for use on non-ffxiv entries for Steam regions without FFXIV
@rankynbass rankynbass requested a review from a team as a code owner October 25, 2024 03:41
@reiichi001 reiichi001 merged commit fb302b8 into goatcorp:main Oct 25, 2024
1 check passed
@rankynbass rankynbass deleted the improve-xlm-launch branch October 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiichi001 reiichi001 reiichi001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rankynbass @reiichi001