Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced login option to start without plugins #204

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

reiichi001
Copy link
Contributor

Feature parity with XIVLauncher WPF.

Adds an option to run the game with Dalamud, but without any plugins.

I only briefly tested this on windows, and xlcore had some other display issues in terms of some imgui tabs, but Dalamud did launch/inject as intended correctly.

This would be best tested on someone's Linux machine to ensure all advanced options continue to work as intended.

Feature parity with XIVLauncher WPF.

Adds an option to run the game with Dalamud, but without any plugins.

I only briefly tested this on windows, and xlcore had some other display issues in terms of some imgui tabs, but Dalamud did launch/inject as intended correctly.

This would be best tested on someone's Linux machine to ensure all advanced options continue to work as intended.
@reiichi001 reiichi001 requested a review from a team as a code owner December 3, 2024 20:14
@sersorrel
Copy link
Contributor

seems to work fine for me on linux (dalamud injects properly, and the xlcore settings don't look obviously broken).

@reiichi001 reiichi001 merged commit 4fbcce1 into goatcorp:main Dec 3, 2024
1 check passed
@reiichi001 reiichi001 deleted the add_start_without_plugins branch December 3, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants