-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Babel, Webpack, React, Eslint, etc to latest & Clean up linting errors #719
base: master
Are you sure you want to change the base?
Changes from all commits
dd607db
e51c658
5ba6705
29e5edd
7d9bec0
d091162
83b9e65
83b37ec
b9c80f8
7119e2e
c2c611e
408c5af
ad3f1c2
35c439a
4e0863f
ab703cf
2535c95
ea92aca
f00268c
0fc08d4
bf941c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,12 +5,23 @@ | |
"browser": true, | ||
"es6": true | ||
}, | ||
"parser": "babel-eslint", | ||
"ecmaFeatures": { | ||
"modules": true, | ||
"jsx": true | ||
}, | ||
"rules": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here, can we revert this file to include only the single rule. We can perhaps add individual overrides per line.
|
||
"comma-dangle": [2, "never"], | ||
"semi": [2, "never"], | ||
} | ||
"arrow-body-style": [2, "always"], | ||
"class-methods-use-this": 0, | ||
"no-console": 0, | ||
"no-param-reassign": 0, | ||
"func-names": 0, | ||
"no-restricted-syntax": 0, | ||
"no-plusplus": 0, | ||
"no-continue": 0, | ||
"no-prototype-builtins": 0, | ||
"prefer-rest-params": 0, | ||
"no-unused-vars": [2, { "args": "none" }], | ||
"no-underscore-dangle": 0, | ||
"react/jsx-filename-extension": 0, | ||
"react/forbid-prop-types": 0, | ||
}, | ||
"parser": "babel-eslint" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't think we need this, but we may need it for some stage-0 features. I'd happily .eslintignore anything that is stage0 though, since it's supposed to be experimental |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
# Changelog | ||
|
||
## 1.0.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh no not yet. |
||
|
||
* Upgrade babel, webpack, react versions to latest | ||
|
||
## 0.18.6 | ||
|
||
* Fixes inheritance for actions #678 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,19 @@ | ||
module.exports = { | ||
context: __dirname + '/src', | ||
context: `${__dirname}/src`, | ||
entry: { | ||
'alt': ['./index.js'], | ||
alt: ['./index.js'] | ||
}, | ||
output: { | ||
path: __dirname + '/dist', | ||
path: `${__dirname}/dist`, | ||
filename: '[name].js', | ||
library: 'Alt', | ||
libraryTarget: 'umd' | ||
}, | ||
module: { | ||
loaders: [{ | ||
test: /\.js$/, | ||
loader: 'babel', | ||
loader: 'babel-loader', | ||
exclude: /node_modules/ | ||
}] | ||
}, | ||
}; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,19 @@ | ||
module.exports = { | ||
context: __dirname + '/src', | ||
context: `${__dirname}/src`, | ||
entry: { | ||
'alt': ['./index.js'], | ||
alt: ['./index.js'] | ||
}, | ||
output: { | ||
path: __dirname + '/dist', | ||
path: `${__dirname}/dist`, | ||
filename: '[name].min.js', | ||
library: 'Alt', | ||
libraryTarget: 'umd' | ||
}, | ||
module: { | ||
loaders: [{ | ||
test: /\.js$/, | ||
loader: 'babel', | ||
loader: 'babel-loader', | ||
exclude: /node_modules/ | ||
}] | ||
}, | ||
}; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep this as-is