Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: improve storage mgmt #13406

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dominic-r
Copy link
Contributor

@dominic-r dominic-r commented Mar 6, 2025

Closes AUTH-X
Closes QA-1
Closes #11939
Closes #13463
Closes #11964
Closes #12985
Closes #11176

Todo

  • Default application icon if load error instead of "Application"
  • Make all tests pass
  • Test with brands
  • Test with filesystem
  • Fix UI Feedback on app creation err for media for example
  • Get the right S3 presigned params (if it even matters)
  • QA

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 33a61f6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67d5c1fba50e040008b648a8

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 33a61f6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67d5c1fb4054a30008fa8a46

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 14.99472% with 805 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (a3f8611) to head (33a61f6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
authentik/root/tests/test_storages.py 15.87% 392 Missing ⚠️
authentik/root/storages.py 13.17% 356 Missing ⚠️
authentik/core/tests/test_applications_api.py 20.58% 27 Missing ⚠️
authentik/lib/utils/file.py 15.38% 22 Missing ⚠️
authentik/core/models.py 0.00% 4 Missing ⚠️
authentik/core/api/applications.py 50.00% 2 Missing ⚠️
authentik/root/settings.py 33.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a3f8611) and HEAD (33a61f6). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (a3f8611) HEAD (33a61f6)
unit 10 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13406       +/-   ##
===========================================
- Coverage   92.68%   71.64%   -21.04%     
===========================================
  Files         794      795        +1     
  Lines       40425    41296      +871     
===========================================
- Hits        37468    29588     -7880     
- Misses       2957    11708     +8751     
Flag Coverage Δ
e2e 47.53% <1.45%> (-0.43%) ⬇️
integration 24.08% <1.45%> (-0.24%) ⬇️
unit 67.15% <14.99%> (-23.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dominic-r dominic-r changed the title core: improve s3 core: improve storage mgmt Mar 6, 2025
@dominic-r dominic-r force-pushed the sdko/core/revamp-s3 branch 2 times, most recently from e560fee to 33f613d Compare March 10, 2025 03:41
@dominic-r dominic-r force-pushed the sdko/core/revamp-s3 branch from 4fe045f to d1e1502 Compare March 15, 2025 02:59
@dominic-r
Copy link
Contributor Author

Ok, ive got a decent working version. Still some things to iron out, tho. I'll make this as ready for review to get a few suggestions/comments

@dominic-r dominic-r marked this pull request as ready for review March 15, 2025 03:02
@dominic-r dominic-r requested review from a team as code owners March 15, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment