-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: add Immich #7829
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for your contribution! A few minor changes, but all in all looks very good :D (and now I don't have to figure out Immich settings when I'll install it at home)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7829 +/- ##
==========================================
- Coverage 92.63% 92.62% -0.01%
==========================================
Files 588 588
Lines 29200 29200
==========================================
- Hits 27049 27047 -2
- Misses 2151 2153 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks like you're missing a make website. If you do not have the tooling, I can run it for you and push it to this PR. |
I did spot |
…plain the list is an example - Fixed a typo with the word "Confidential" - Changed placeholder for Immich to be the URL, including https://
Apologies, this is new to me and I'm getting this error and I'm unsure how to resolve it
|
No worries. The command is simply |
I should've said that I tried that but got this...
So tried it with nodejs in front as the documentation says it's required |
Worked it out, was trying to run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this contribution! Just a few grammar nitpicks, punctuation, but LGTM!
Thank you, I'll keep the wording / language in mind for an future PRs 😄 All issues mentioned fixed in 07febfa |
Create documentation for the Immich application
Adding in documentation for Immich. This doesn't close a PR but will help anyone else attempting to set up the application in authentik
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)make i18n-extract
)If applicable
make website
)