Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: bump python deps (django 5) #7862

Merged
merged 10 commits into from
Dec 18, 2023
Merged

root: bump python deps (django 5) #7862

merged 10 commits into from
Dec 18, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Dec 12, 2023

Details

Dependabot doesn't support python 3.12 so we have to manually bump python dependencies....sigh

This bumps us to django 5.0 (and also backports the pickle serializer that was removed in 5.0 since we still rely on it (see #7761)

Also a new version of drf_spectacular so a regenerated api scheme


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners December 12, 2023 11:01
Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for authentik-storybook failed.

Name Link
🔨 Latest commit ae44040
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6580b21757cc630008a6ee22

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ba174d8) 92.62% compared to head (ae44040) 92.62%.

Files Patch % Lines
authentik/root/sessions/pickle.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7862   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files         588      589    +1     
  Lines       29200    29217   +17     
=======================================
+ Hits        27047    27063   +16     
- Misses       2153     2154    +1     
Flag Coverage Δ
e2e 50.67% <92.59%> (+0.02%) ⬆️
integration 25.92% <59.25%> (+0.01%) ⬆️
unit 89.70% <94.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the root/bump-python branch 2 times, most recently from 75d83dd to 9dffdb1 Compare December 12, 2023 12:47
Copy link
Contributor

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

@BeryJu BeryJu changed the title root: bump python deps root: bump python deps (django 5) Dec 12, 2023
Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 406fcc7
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6580b09e182bb30008977489
😎 Deploy Preview https://deploy-preview-7862--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu BeryJu requested a review from a team as a code owner December 18, 2023 20:49
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
?
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu merged commit 729ef4d into main Dec 18, 2023
58 of 63 checks passed
@BeryJu BeryJu deleted the root/bump-python branch December 18, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant