Fix use-after-free in infinoted when uploading a document (gobby#142)

gobby · Feb 28, 2017 · a515e79 · a515e79
1 parent e59c1a4
commit a515e79
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/libinfinity/server/infd-directory.c b/libinfinity/server/infd-directory.c
@@ -3637,6 +3637,7 @@ infd_directory_sync_in_synchronization_complete_cb(InfSession* session,
    * tree. */
   InfdDirectorySyncIn* sync_in;
   InfdDirectory* directory;
+  const InfdNotePlugin* plugin;
   InfdDirectoryPrivate* priv;
   InfdDirectoryNode* node;
   InfBrowserIter iter;
@@ -3649,6 +3650,7 @@ infd_directory_sync_in_synchronization_complete_cb(InfSession* session,
 
   sync_in = (InfdDirectorySyncIn*)user_data;
   directory = sync_in->directory;
+  plugin = sync_in->plugin;
   priv = INFD_DIRECTORY_PRIVATE(directory);
 
   node = infd_directory_node_new_note(
@@ -3683,11 +3685,11 @@ infd_directory_sync_in_synchronization_complete_cb(InfSession* session,
 
   if(priv->storage != NULL)
   {
-    ret = sync_in->plugin->session_write(
+    ret = plugin->session_write(
       priv->storage,
       session,
       path,
-      sync_in->plugin->user_data,
+      plugin->user_data,
       &error
     );
   }