Skip to content

Commit

Permalink
Update TODO comment about base earlyglobs flow-insensitive invariants
Browse files Browse the repository at this point in the history
  • Loading branch information
sim642 committed Jul 31, 2024
1 parent 6055e8d commit 6e79314
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/analyses/base.ml
Original file line number Diff line number Diff line change
Expand Up @@ -1247,8 +1247,8 @@ struct
let query_invariant_global ctx g =
if GobConfig.get_bool "ana.base.invariant.enabled" then (
(* Currently these global invariants are only sound with earlyglobs enabled for both single- and multi-threaded programs.
Otherwise, the values of globals in single-threaded mode are not accounted for. *)
(* TODO: account for single-threaded values without earlyglobs. *)
Otherwise, the values of globals in single-threaded mode are not accounted for.
They are also made sound without earlyglobs using the multithreaded mode ghost variable. *)
match g with
| `Left g' -> (* priv *)
let inv = Priv.invariant_global (Analyses.ask_of_ctx ctx) (priv_getg ctx.global) g' in
Expand Down

0 comments on commit 6e79314

Please sign in to comment.