Skip to content

Commit

Permalink
Remove TODO annotations from passing checks
Browse files Browse the repository at this point in the history
  • Loading branch information
sim642 committed Sep 27, 2023
1 parent 5347c08 commit eb97eca
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions tests/regression/01-cpa/33-asserts.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ int main(){
check(j==6); // assert UNKNOWN

unknown(&k);
assume(k==4); // TODO? assert SUCCESS
assume(k==4);
check(k==4); // assert SUCCESS

unknown(&k);
assume(k+1==n); // TODO? FAIL
assume(k+1==n);

assume(n==5); // TODO? NOWARN
assert(0); // NOWARN
assume(n==5); // contradiction
assert(0); // NOWARN (unreachable)

return 0;
}
2 changes: 1 addition & 1 deletion tests/regression/28-race_reach/22-deref_read_racefree.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ int main() {
create_threads(t);
q = p;
pthread_mutex_lock(&mutex);
assert_racefree(*q); // TODO
assert_racefree(*q);
pthread_mutex_unlock(&mutex);
return 0;
}
6 changes: 3 additions & 3 deletions tests/regression/66-interval-set-one/51-widen-sides.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@

int further(int n) {
// Even sides-local can not save us here :(
__goblint_check(n <= 1); //TODO
__goblint_check(n <= 2); //TODO
}


int fun(int n, const char* arg) {
// Fails with solvers.td3.side_widen sides, needs sides-local
__goblint_check(n <= 1);
__goblint_check(n <= 2);
further(n);
}

Expand All @@ -26,5 +26,5 @@ int main() {
doIt("two");

// In the setting with solvers.td3.side_widen sides, widening happens and the bound is lost
fun(1, "org");
fun(2, "org");
}

0 comments on commit eb97eca

Please sign in to comment.