ThreadCreate analysis to improve partially context-sensitive threadID analysis #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by:FelixKrayer<[email protected]>
Co-authored-by:FelixKrayer<[email protected]>
1 task
sim642
reviewed
Jun 12, 2023
| @@ -0,0 +1,32 @@ | |||
| // PARAM: --disable ana.thread.context.create-edges | |||
There was a problem hiding this comment.
All these tests disable the new option, so aren't they just testing the old behavior without the edges?
Seems like there should be tests for the cases where enabling the new option actually makes us more precise than before as well.
There was a problem hiding this comment.
The option is active by default as that corresponds to the old behavior. What the changes in here are about is holding on to more precision, when reducing the amount of context-sensitivity.
Co-authored-by: Simmo Saan <[email protected]>
|
@sim642 When you get a chance, can you have a look? The comments should be addressed, and it would be nice to have this merged before it becomes stale again. |
sim642
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reimplementation of #1007 to play nice with the new uniqueness counter integrating the analysis into the
threadIdanalysis as suggested in #1007 (comment).Original implementation by @FelixKrayer.